Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Scalar assignment in Python from single value #23788

Merged
merged 1 commit into from Jun 13, 2023

Conversation

dkurt
Copy link
Member

@dkurt dkurt commented Jun 13, 2023

Pull Request Readiness Checklist

resolves #23764

I don't think that scalefactor as a Scalar is a good idea. Is there models with different scales for channels?

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-alalek opencv-alalek added the backport is needed Label for maintainers. Authors of PR can ignore this label Jun 13, 2023
@opencv-alalek opencv-alalek added this to the 4.8.0 milestone Jun 13, 2023
@dkurt dkurt marked this pull request as ready for review June 13, 2023 13:09
@asmorkalov asmorkalov merged commit b522148 into opencv:4.x Jun 13, 2023
21 checks passed
@dkurt dkurt deleted the py_scalar_assign branch June 13, 2023 15:36
@asmorkalov asmorkalov mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport is needed Label for maintainers. Authors of PR can ignore this bug category: python bindings test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Scalar is different with C++
3 participants