Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSoC: Modified PLY reader to support color attribute read/write #23805

Merged
merged 4 commits into from
Jul 25, 2023
Merged

GSoC: Modified PLY reader to support color attribute read/write #23805

merged 4 commits into from
Jul 25, 2023

Conversation

starga2er777
Copy link

@starga2er777 starga2er777 commented Jun 15, 2023 •
edited by WanliZhong
Loading

Pull Request Readiness Checklist

Merged with opencv/opencv_extra#1075

Issue for GSoC 2023
The ply loader in 3D module doesn't support color attribute reading. I modified that to support color attribute reading & writing for the color attribute compression as described in proposal.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 5.0 milestone Jun 15, 2023
@starga2er777 starga2er777 changed the title Modified PLY reader to support color attribute read/write GSoC: Modified PLY reader to support color attribute read/write Jun 15, 2023
@WanliZhong WanliZhong mentioned this pull request Jun 29, 2023
Open
6 tasks
@asmorkalov asmorkalov added the GSoC label Jul 6, 2023
asmorkalov
asmorkalov requested changes Jul 6, 2023
View reviewed changes
modules/3d/test/test_pointcloud.cpp Show resolved Hide resolved
modules/3d/src/pointcloud/io_ply.cpp Outdated Show resolved Hide resolved
modules/3d/src/pointcloud/io_obj.cpp Outdated Show resolved Hide resolved
@starga2er777 starga2er777 mentioned this pull request Jul 14, 2023
Merged
@asmorkalov asmorkalov self-assigned this Jul 18, 2023
asmorkalov
asmorkalov approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 4d695cd into opencv:5.x Jul 25, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
category: 3d module GSoC
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@starga2er777 @asmorkalov