Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unreachable codes in gbackend #23904

Merged
merged 1 commit into from Sep 4, 2023

Conversation

kai-waang
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@dmatveev
Copy link
Contributor

Hi @kai-waang ! Thanks for this PR. Does this code cause warnings so you decided to remove it? Could you please specify details of your platform if it causes any troubles? No objections with the PR but trying to understand the background.

@kai-waang
Copy link
Contributor Author

Hi @kai-waang ! Thanks for this PR. Does this code cause warnings so you decided to remove it? Could you please specify details of your platform if it causes any troubles? No objections with the PR but trying to understand the background.

I think this PR is made when I was reading these codes and trying to do some cleaning. I'm sure it doesn't cause any warnings on my machine.

Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe (back in 2017) this code has been written to avoid some warnings.. But if it passes the current CI, there's no such warnings in 2023.

At least it is always possible to revert it in case of problems

Thanks for your contribution!

@asmorkalov asmorkalov added this to the 4.9.0 milestone Sep 4, 2023
@asmorkalov asmorkalov merged commit 748279d into opencv:4.x Sep 4, 2023
20 of 21 checks passed
@asmorkalov asmorkalov mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants