Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update NumPy type to Mat type fail message #23958

Merged

Conversation

VadimLevin
Copy link
Contributor

Output string representation of NumPy array type if it is not convertible to OpenCV Mat type

Example output from the test:

cv2.error: OpenCV(4.8.0-dev) :-1: error: (-5:Bad argument) in function 'dumpInputArray'
> Overload resolution failed:
>  - argument data type = object is not supported
>  - Expected Ptr<cv::UMat> for argument 'argument'

Resolves: #23106

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Output string representation of NumPy array type if it is not
convertible to OpenCV Mat type
@VadimLevin VadimLevin force-pushed the dev/vlevin/friendly-wrong-npy-type-message branch from c1f8757 to 953de60 Compare July 10, 2023 15:09
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 6af4a02 into opencv:4.x Jul 11, 2023
20 of 21 checks passed
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants