Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Update octree methods and create frame for PCC #23959

Closed
wants to merge 7 commits into from

Conversation

starga2er777
Copy link

PR for GSoC Point Cloud Compression

Issue for GSoC 2023

  • We are updating the Octree method create() by using OctreeKey: Through voxelization, directly calculate the leaf nodes that the point cloud belongs to, and omit the judgment whether the point cloud is in the range when inserted. The index of the child node is calculated by bit operation.
  • We are also introducing a new header file pcc.h (Point Cloud Compression) with API framework.
  • We added tests for restoring point clouds from an octree.
  • Currently, the features related to octree creation and point cloud compression are part of the internal API, which means they are not directly accessible to users. However, our plan for the future is to include only the 'PointCloudCompression' class in the 'opencv2/3d.hpp' header file. This will provide an interface for utilizing the point cloud compression functionality.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@WanliZhong
Copy link
Member

WanliZhong commented Jul 11, 2023

@opencv-alalek @asmorkalov Hi, Why his code will pull opencv_contrib_merge in default CI? Seems like they fork OpenCV and rename the repository to opencv_contrib, the name is conflict.
image

Should they need to rename their repository name to opencv not opencv_contrib and re-create this PR?

@opencv-alalek
Copy link
Contributor

Why?

May be because main repo is not opencv but opencv_contrib in this PR.

starga2er777 wants to merge 5 commits into opencv:5.x from starga2er777:pcc

[starga2er777](https://github.com/starga2er777) wants to merge 5 commits into [opencv:5.x](https://github.com/opencv/opencv/tree/5.x) from [starga2er777:pcc](https://github.com/starga2er777/opencv_contrib/tree/pcc)

@starga2er777
Copy link
Author

Closing this PR due to conflict on repository name.

@starga2er777
Copy link
Author

Reopen in: #23985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants