In-house QR codes decoding #24299

dkurt · 2023-09-20T03:57:13Z

Pull Request Readiness Checklist

QR codes decoding pipeline without 3rdparty dependency (Quirc library). Implemented according to standard https://github.com/yansikeim/QR-Code/blob/master/ISO%20IEC%2018004%202015%20Standard.pdf

Merge with extra: opencv/opencv_extra#1124

resolves #24225
resolves #17290
resolves #24318 #24346

Resources:

Geometric mean (ms)

                                   Name of Test                                      quirc   new2      new2   
                                                                                                        vs    
                                                                                                      quirc   
                                                                                                    (x-factor)
decode::Perf_Objdetect_Not_QRCode::("chessboard", 640x480)                           9.151   9.157     1.00   
decode::Perf_Objdetect_Not_QRCode::("chessboard", 1280x720)                         21.609  21.609     1.00   
decode::Perf_Objdetect_Not_QRCode::("chessboard", 1920x1080)                        42.088  41.924     1.00   
decode::Perf_Objdetect_Not_QRCode::("chessboard", 3840x2160)                        169.737 169.050    1.00   
decode::Perf_Objdetect_Not_QRCode::("random", 640x480)                               8.552   8.611     0.99   
decode::Perf_Objdetect_Not_QRCode::("random", 1280x720)                             21.264  21.581     0.99   
decode::Perf_Objdetect_Not_QRCode::("random", 1920x1080)                            42.415  43.468     0.98   
decode::Perf_Objdetect_Not_QRCode::("random", 3840x2160)                            175.003 174.294    1.00   
decode::Perf_Objdetect_Not_QRCode::("zero", 640x480)                                 8.528   8.421     1.01   
decode::Perf_Objdetect_Not_QRCode::("zero", 1280x720)                               21.548  21.209     1.02   
decode::Perf_Objdetect_Not_QRCode::("zero", 1920x1080)                              42.581  42.529     1.00   
decode::Perf_Objdetect_Not_QRCode::("zero", 3840x2160)                              176.231 174.410    1.01   
decode::Perf_Objdetect_QRCode::"kanji.jpg"                                           6.105   6.072     1.01   
decode::Perf_Objdetect_QRCode::"link_github_ocv.jpg"                                 6.069   6.076     1.00   
decode::Perf_Objdetect_QRCode::"link_ocv.jpg"                                        6.143   6.240     0.98   
decode::Perf_Objdetect_QRCode::"link_wiki_cv.jpg"                                    6.369   6.420     0.99   
decode::Perf_Objdetect_QRCode::"russian.jpg"                                         6.558   6.549     1.00   
decode::Perf_Objdetect_QRCode::"version_1_down.jpg"                                  5.634   5.621     1.00   
decode::Perf_Objdetect_QRCode::"version_1_left.jpg"                                  5.560   5.609     0.99   
decode::Perf_Objdetect_QRCode::"version_1_right.jpg"                                 5.539   5.631     0.98   
decode::Perf_Objdetect_QRCode::"version_1_top.jpg"                                   5.622   5.566     1.01   
decode::Perf_Objdetect_QRCode::"version_1_up.jpg"                                    5.569   5.534     1.01   
decode::Perf_Objdetect_QRCode::"version_5_down.jpg"                                  6.514   6.436     1.01   
decode::Perf_Objdetect_QRCode::"version_5_left.jpg"                                  6.668   6.479     1.03   
decode::Perf_Objdetect_QRCode::"version_5_top.jpg"                                   6.481   6.484     1.00   
decode::Perf_Objdetect_QRCode::"version_5_up.jpg"                                    7.011   6.513     1.08   
decodeMulti::Perf_Objdetect_QRCode_Multi::("2_qrcodes.png", "aruco_based")          14.885  15.089     0.99   
decodeMulti::Perf_Objdetect_QRCode_Multi::("2_qrcodes.png", "contours_based")       14.896  14.906     1.00   
decodeMulti::Perf_Objdetect_QRCode_Multi::("3_close_qrcodes.png", "aruco_based")     6.661   6.663     1.00   
decodeMulti::Perf_Objdetect_QRCode_Multi::("3_close_qrcodes.png", "contours_based")  6.614   6.592     1.00   
decodeMulti::Perf_Objdetect_QRCode_Multi::("3_qrcodes.png", "aruco_based")          14.814  14.592     1.02   
decodeMulti::Perf_Objdetect_QRCode_Multi::("3_qrcodes.png", "contours_based")       15.245  15.135     1.01   
decodeMulti::Perf_Objdetect_QRCode_Multi::("4_qrcodes.png", "aruco_based")          10.923  10.881     1.00   
decodeMulti::Perf_Objdetect_QRCode_Multi::("4_qrcodes.png", "contours_based")       10.680  10.128     1.05   
decodeMulti::Perf_Objdetect_QRCode_Multi::("5_qrcodes.png", "contours_based")       11.788  11.576     1.02   
decodeMulti::Perf_Objdetect_QRCode_Multi::("6_qrcodes.png", "aruco_based")          25.887  25.979     1.00   
decodeMulti::Perf_Objdetect_QRCode_Multi::("6_qrcodes.png", "contours_based")       26.183  25.627     1.02   
decodeMulti::Perf_Objdetect_QRCode_Multi::("7_qrcodes.png", "aruco_based")          32.786  32.253     1.02   
decodeMulti::Perf_Objdetect_QRCode_Multi::("7_qrcodes.png", "contours_based")       24.290  24.435     0.99   
decodeMulti::Perf_Objdetect_QRCode_Multi::("8_close_qrcodes.png", "aruco_based")    89.696  89.247     1.01   
decodeMulti::Perf_Objdetect_QRCode_Multi::("8_close_qrcodes.png", "contours_based") 89.872  89.600     1.00

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

force_builders=Custom
build_image:Docs=docs-js:18.04
build_image:Custom=javascript
buildworker:Custom=linux-1,linux-4,linux-f1

modules/objdetect/include/opencv2/objdetect.hpp

CMakeLists.txt

modules/objdetect/src/qrcode_encoder.cpp

AleksandrPanov · 2023-11-17T16:21:23Z

don't forget to rebase with 4.x
@dkurt, tested new decoder with openCV bencmark (total 1232 QR codes). The regressions in decoding was detected. This command line was used:
python qr.py -p=qrcodes/detection -a=0.3 --metric=intersection_over_union -alg=opencv_aruco

presumably, quirc_decode() clarifies the corners of the QR code and therefore gets the correct answer in some cases.

Sample img_qrcodes_detection_brightness_image022:

There are 3 QR codes with data:

Version 1 QR
ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789
Version 2 QR Code Test Image

detectAndDecode with quirc:

[[[541.      429.99997]
  [629.      428.     ]
  [625.9286  514.     ]
  [541.      514.     ]]

 [[366.      418.     ]
  [374.      597.     ]
  [197.29529 601.6301 ]
  [186.      425.     ]]

 [[490.      595.     ]
  [590.      600.     ]
  [583.2835  698.9752 ]
  [484.      692.     ]]]
('', 'ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789', 'Version 2 QR Code Test Image')

detectAndDecode with new decode method:

[[[541.      429.99997]
  [629.      428.     ]
  [625.9286  514.     ]
  [541.      514.     ]]

 [[366.      418.     ]
  [374.      597.     ]
  [197.29529 601.6301 ]
  [186.      425.     ]]

 [[489.99997 595.     ]
  [590.      600.     ]
  [583.0866  699.14197]
  [484.      692.     ]]]
('', 'ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789 ABC 123456789', '')

The two methods give two different corners [583.2835 698.9752 ] vs [583.0866 699.14197]

python script:

import numpy as np
import cv2 as cv

image = cv.imread("image022.jpg")
detector = cv.QRCodeDetectorAruco()
found, points, decode_info, _ = detector.detectAndDecodeMulti(image)
print(decode_info)
print(points)

If the problem is in the refinement of the corners, you can copy the QUIRC implementation. There may be problems with rounding.

AleksandrPanov

need to check regressions

dkurt · 2023-11-17T16:42:05Z

Thanks @AleksandrPanov ! This is the benchmark I was looking for. Will use it.

AleksandrPanov · 2023-11-17T18:09:19Z

@dkurt, benchmark write out.yaml with detect/decode info, you could use file compare to check regressions.
out_dcurt.yaml.txt
out_pre_4.9.yaml.txt

Also you need download BoofCV dataset to path_folder.

dkurt · 2023-11-17T18:54:04Z

Great, thanks. Make sense add regressed samples to OpenCV during this activity as existing set of tests passed.

dkurt · 2023-11-20T11:31:52Z

@AleksandrPanov, I have fixed the difference between Quirc and OpenCV with the following patch 9dc9f42 by increasing number of error correction syndromes. Now both .yaml reports are identical. Tests were added.

modules/objdetect/test/test_qrcode_encode.cpp

asmorkalov · 2023-11-22T07:11:08Z

modules/objdetect/src/qrcode_encoder.cpp

+
+// Unmask format info bits and apply error correction
+bool QRCodeDecoderImpl::correctFormatInfo(uint16_t& format_info) {
+    static uint16_t mask_pattern = 0b101010000010010;


please add reference to the constant origin or how it was generated.

This is a mask similar to

opencv/modules/objdetect/src/qrcode_encoder.cpp

Line 435 in 2c1ec42

const uint8_t generator_arr[generator_len] = {1, 0, 1, 0, 0, 1, 0, 0, 1, 1, 1, 1, 1};

.

modules/objdetect/src/qrcode_encoder.cpp

asmorkalov · 2023-11-22T07:32:13Z

@dkurt could you also modify CMake to disable QUIRC by default. All CI jobs will test your branch then.

dkurt · 2023-11-22T08:54:03Z

@asmorkalov, I did this before but I'm not sure if it's ok to switch it by default right before the next release.

asmorkalov · 2023-11-22T09:29:07Z

We can roll it back before merge. I need CI status for your for review.

asmorkalov

👍

asmorkalov · 2023-11-23T12:51:10Z

@AleksandrPanov Please attach updated benchmark result.

AleksandrPanov · 2023-11-23T14:13:11Z

AleksandrPanov · 2023-11-23T14:13:55Z

there are no more regressions
👍

In-house QR codes decoding opencv#24299 ### Pull Request Readiness Checklist QR codes decoding pipeline without 3rdparty dependency (Quirc library). Implemented according to standard https://github.com/yansikeim/QR-Code/blob/master/ISO%20IEC%2018004%202015%20Standard.pdf **Merge with extra**: opencv/opencv_extra#1124 resolves opencv#24225 resolves opencv#17290 resolves opencv#24318 opencv#24346 Resources: * https://en.wikiversity.org/wiki/Reed%E2%80%93Solomon_codes_for_coders * https://en.wikipedia.org/wiki/Berlekamp%E2%80%93Massey_algorithm ``` Geometric mean (ms) Name of Test quirc new2 new2 vs quirc (x-factor) decode::Perf_Objdetect_Not_QRCode::("chessboard", 640x480) 9.151 9.157 1.00 decode::Perf_Objdetect_Not_QRCode::("chessboard", 1280x720) 21.609 21.609 1.00 decode::Perf_Objdetect_Not_QRCode::("chessboard", 1920x1080) 42.088 41.924 1.00 decode::Perf_Objdetect_Not_QRCode::("chessboard", 3840x2160) 169.737 169.050 1.00 decode::Perf_Objdetect_Not_QRCode::("random", 640x480) 8.552 8.611 0.99 decode::Perf_Objdetect_Not_QRCode::("random", 1280x720) 21.264 21.581 0.99 decode::Perf_Objdetect_Not_QRCode::("random", 1920x1080) 42.415 43.468 0.98 decode::Perf_Objdetect_Not_QRCode::("random", 3840x2160) 175.003 174.294 1.00 decode::Perf_Objdetect_Not_QRCode::("zero", 640x480) 8.528 8.421 1.01 decode::Perf_Objdetect_Not_QRCode::("zero", 1280x720) 21.548 21.209 1.02 decode::Perf_Objdetect_Not_QRCode::("zero", 1920x1080) 42.581 42.529 1.00 decode::Perf_Objdetect_Not_QRCode::("zero", 3840x2160) 176.231 174.410 1.01 decode::Perf_Objdetect_QRCode::"kanji.jpg" 6.105 6.072 1.01 decode::Perf_Objdetect_QRCode::"link_github_ocv.jpg" 6.069 6.076 1.00 decode::Perf_Objdetect_QRCode::"link_ocv.jpg" 6.143 6.240 0.98 decode::Perf_Objdetect_QRCode::"link_wiki_cv.jpg" 6.369 6.420 0.99 decode::Perf_Objdetect_QRCode::"russian.jpg" 6.558 6.549 1.00 decode::Perf_Objdetect_QRCode::"version_1_down.jpg" 5.634 5.621 1.00 decode::Perf_Objdetect_QRCode::"version_1_left.jpg" 5.560 5.609 0.99 decode::Perf_Objdetect_QRCode::"version_1_right.jpg" 5.539 5.631 0.98 decode::Perf_Objdetect_QRCode::"version_1_top.jpg" 5.622 5.566 1.01 decode::Perf_Objdetect_QRCode::"version_1_up.jpg" 5.569 5.534 1.01 decode::Perf_Objdetect_QRCode::"version_5_down.jpg" 6.514 6.436 1.01 decode::Perf_Objdetect_QRCode::"version_5_left.jpg" 6.668 6.479 1.03 decode::Perf_Objdetect_QRCode::"version_5_top.jpg" 6.481 6.484 1.00 decode::Perf_Objdetect_QRCode::"version_5_up.jpg" 7.011 6.513 1.08 decodeMulti::Perf_Objdetect_QRCode_Multi::("2_qrcodes.png", "aruco_based") 14.885 15.089 0.99 decodeMulti::Perf_Objdetect_QRCode_Multi::("2_qrcodes.png", "contours_based") 14.896 14.906 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("3_close_qrcodes.png", "aruco_based") 6.661 6.663 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("3_close_qrcodes.png", "contours_based") 6.614 6.592 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("3_qrcodes.png", "aruco_based") 14.814 14.592 1.02 decodeMulti::Perf_Objdetect_QRCode_Multi::("3_qrcodes.png", "contours_based") 15.245 15.135 1.01 decodeMulti::Perf_Objdetect_QRCode_Multi::("4_qrcodes.png", "aruco_based") 10.923 10.881 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("4_qrcodes.png", "contours_based") 10.680 10.128 1.05 decodeMulti::Perf_Objdetect_QRCode_Multi::("5_qrcodes.png", "contours_based") 11.788 11.576 1.02 decodeMulti::Perf_Objdetect_QRCode_Multi::("6_qrcodes.png", "aruco_based") 25.887 25.979 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("6_qrcodes.png", "contours_based") 26.183 25.627 1.02 decodeMulti::Perf_Objdetect_QRCode_Multi::("7_qrcodes.png", "aruco_based") 32.786 32.253 1.02 decodeMulti::Perf_Objdetect_QRCode_Multi::("7_qrcodes.png", "contours_based") 24.290 24.435 0.99 decodeMulti::Perf_Objdetect_QRCode_Multi::("8_close_qrcodes.png", "aruco_based") 89.696 89.247 1.01 decodeMulti::Perf_Objdetect_QRCode_Multi::("8_close_qrcodes.png", "contours_based") 89.872 89.600 1.00 ```

QR codes Structured Append decoding mode #24548 ### Pull Request Readiness Checklist resolves #23245 Merge after #24299 Current proposal is to use `detectAndDecodeMulti` or `decodeMulti` for structured append mode decoding. 0-th QR code in a sequence gets a full message while the rest of codes will correspond to empty strings. See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake

In-house QR codes decoding opencv#24299 ### Pull Request Readiness Checklist QR codes decoding pipeline without 3rdparty dependency (Quirc library). Implemented according to standard https://github.com/yansikeim/QR-Code/blob/master/ISO%20IEC%2018004%202015%20Standard.pdf **Merge with extra**: opencv/opencv_extra#1124 resolves opencv#24225 resolves opencv#17290 resolves opencv#24318 opencv#24346 Resources: * https://en.wikiversity.org/wiki/Reed%E2%80%93Solomon_codes_for_coders * https://en.wikipedia.org/wiki/Berlekamp%E2%80%93Massey_algorithm ``` Geometric mean (ms) Name of Test quirc new2 new2 vs quirc (x-factor) decode::Perf_Objdetect_Not_QRCode::("chessboard", 640x480) 9.151 9.157 1.00 decode::Perf_Objdetect_Not_QRCode::("chessboard", 1280x720) 21.609 21.609 1.00 decode::Perf_Objdetect_Not_QRCode::("chessboard", 1920x1080) 42.088 41.924 1.00 decode::Perf_Objdetect_Not_QRCode::("chessboard", 3840x2160) 169.737 169.050 1.00 decode::Perf_Objdetect_Not_QRCode::("random", 640x480) 8.552 8.611 0.99 decode::Perf_Objdetect_Not_QRCode::("random", 1280x720) 21.264 21.581 0.99 decode::Perf_Objdetect_Not_QRCode::("random", 1920x1080) 42.415 43.468 0.98 decode::Perf_Objdetect_Not_QRCode::("random", 3840x2160) 175.003 174.294 1.00 decode::Perf_Objdetect_Not_QRCode::("zero", 640x480) 8.528 8.421 1.01 decode::Perf_Objdetect_Not_QRCode::("zero", 1280x720) 21.548 21.209 1.02 decode::Perf_Objdetect_Not_QRCode::("zero", 1920x1080) 42.581 42.529 1.00 decode::Perf_Objdetect_Not_QRCode::("zero", 3840x2160) 176.231 174.410 1.01 decode::Perf_Objdetect_QRCode::"kanji.jpg" 6.105 6.072 1.01 decode::Perf_Objdetect_QRCode::"link_github_ocv.jpg" 6.069 6.076 1.00 decode::Perf_Objdetect_QRCode::"link_ocv.jpg" 6.143 6.240 0.98 decode::Perf_Objdetect_QRCode::"link_wiki_cv.jpg" 6.369 6.420 0.99 decode::Perf_Objdetect_QRCode::"russian.jpg" 6.558 6.549 1.00 decode::Perf_Objdetect_QRCode::"version_1_down.jpg" 5.634 5.621 1.00 decode::Perf_Objdetect_QRCode::"version_1_left.jpg" 5.560 5.609 0.99 decode::Perf_Objdetect_QRCode::"version_1_right.jpg" 5.539 5.631 0.98 decode::Perf_Objdetect_QRCode::"version_1_top.jpg" 5.622 5.566 1.01 decode::Perf_Objdetect_QRCode::"version_1_up.jpg" 5.569 5.534 1.01 decode::Perf_Objdetect_QRCode::"version_5_down.jpg" 6.514 6.436 1.01 decode::Perf_Objdetect_QRCode::"version_5_left.jpg" 6.668 6.479 1.03 decode::Perf_Objdetect_QRCode::"version_5_top.jpg" 6.481 6.484 1.00 decode::Perf_Objdetect_QRCode::"version_5_up.jpg" 7.011 6.513 1.08 decodeMulti::Perf_Objdetect_QRCode_Multi::("2_qrcodes.png", "aruco_based") 14.885 15.089 0.99 decodeMulti::Perf_Objdetect_QRCode_Multi::("2_qrcodes.png", "contours_based") 14.896 14.906 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("3_close_qrcodes.png", "aruco_based") 6.661 6.663 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("3_close_qrcodes.png", "contours_based") 6.614 6.592 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("3_qrcodes.png", "aruco_based") 14.814 14.592 1.02 decodeMulti::Perf_Objdetect_QRCode_Multi::("3_qrcodes.png", "contours_based") 15.245 15.135 1.01 decodeMulti::Perf_Objdetect_QRCode_Multi::("4_qrcodes.png", "aruco_based") 10.923 10.881 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("4_qrcodes.png", "contours_based") 10.680 10.128 1.05 decodeMulti::Perf_Objdetect_QRCode_Multi::("5_qrcodes.png", "contours_based") 11.788 11.576 1.02 decodeMulti::Perf_Objdetect_QRCode_Multi::("6_qrcodes.png", "aruco_based") 25.887 25.979 1.00 decodeMulti::Perf_Objdetect_QRCode_Multi::("6_qrcodes.png", "contours_based") 26.183 25.627 1.02 decodeMulti::Perf_Objdetect_QRCode_Multi::("7_qrcodes.png", "aruco_based") 32.786 32.253 1.02 decodeMulti::Perf_Objdetect_QRCode_Multi::("7_qrcodes.png", "contours_based") 24.290 24.435 0.99 decodeMulti::Perf_Objdetect_QRCode_Multi::("8_close_qrcodes.png", "aruco_based") 89.696 89.247 1.01 decodeMulti::Perf_Objdetect_QRCode_Multi::("8_close_qrcodes.png", "contours_based") 89.872 89.600 1.00 ```

dkurt commented Sep 20, 2023

View reviewed changes

modules/objdetect/include/opencv2/objdetect.hpp Outdated Show resolved Hide resolved

dkurt mentioned this pull request Sep 22, 2023

Implement QR Code decoder and encoder #17290

Closed

4 tasks

dkurt force-pushed the qrcode_decode branch from 33be837 to 1a67e54 Compare September 28, 2023 10:48

dkurt marked this pull request as ready for review September 28, 2023 16:28

dkurt mentioned this pull request Oct 1, 2023

QRCodeDetector::detectAndDecode doesn't decode #24346

Closed

4 tasks

dkurt linked an issue Oct 1, 2023 that may be closed by this pull request

QRCodeDetector::detectAndDecode doesn't decode #24346

Closed

4 tasks

dkurt commented Oct 4, 2023

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

dkurt force-pushed the qrcode_decode branch from 306cab3 to 38a62c1 Compare October 13, 2023 18:29

dkurt requested review from opencv-alalek and AleksandrPanov October 25, 2023 10:36

dkurt force-pushed the qrcode_decode branch from 9287c83 to 16a08be Compare November 13, 2023 06:52

mshabunin reviewed Nov 14, 2023

View reviewed changes

modules/objdetect/src/qrcode_encoder.cpp Outdated Show resolved Hide resolved

modules/objdetect/src/qrcode_encoder.cpp Outdated Show resolved Hide resolved

dkurt force-pushed the qrcode_decode branch 2 times, most recently from 47be7a2 to 0c6ef64 Compare November 15, 2023 10:01

dkurt mentioned this pull request Nov 15, 2023

QR codes Structured Append decoding mode #24548

Merged

6 tasks

AleksandrPanov requested changes Nov 17, 2023

View reviewed changes

dkurt added 7 commits November 20, 2023 12:26

In-house QR codes decoding

bbc3fc5

Update with UTF-8 correction

ac77f90

Fix warning

126271d

Use format info LUT for encoder

f29ec14

Avoid potential data race

f4a431d

Use decoder with class

5d99747

Enable Quirc by default

628b0ce

dkurt force-pushed the qrcode_decode branch from 28700fd to 4881108 Compare November 20, 2023 11:30

Increase number of syndromes for 1M and 2L codes

9dc9f42

dkurt force-pushed the qrcode_decode branch from 4881108 to 9dc9f42 Compare November 20, 2023 12:13

asmorkalov reviewed Nov 22, 2023

View reviewed changes

Resolve comments

6d8f6c3

dkurt force-pushed the qrcode_decode branch from 788fb37 to 6d8f6c3 Compare November 22, 2023 10:24

asmorkalov approved these changes Nov 23, 2023

View reviewed changes

AleksandrPanov self-requested a review November 23, 2023 16:51

AleksandrPanov approved these changes Nov 23, 2023

View reviewed changes

asmorkalov assigned AleksandrPanov Nov 24, 2023

asmorkalov added feature category: objdetect labels Nov 24, 2023

asmorkalov added this to the 4.9.0 milestone Nov 24, 2023

asmorkalov merged commit d296d29 into opencv:4.x Nov 24, 2023
26 checks passed

opencv-alalek removed their request for review December 26, 2023 20:46

asmorkalov mentioned this pull request Jan 19, 2024

5.x merge 4.x #24862

Merged

PeterBowman mentioned this pull request Jan 20, 2024

Replace QR code detection backend roboticslab-uc3m/vision#110

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In-house QR codes decoding #24299

In-house QR codes decoding #24299

dkurt commented Sep 20, 2023 •

edited by opencv-alalek

Loading

AleksandrPanov commented Nov 17, 2023 •

edited

Loading

AleksandrPanov left a comment

dkurt commented Nov 17, 2023

AleksandrPanov commented Nov 17, 2023

dkurt commented Nov 17, 2023

dkurt commented Nov 20, 2023 •

edited

Loading

asmorkalov Nov 22, 2023

dkurt Nov 22, 2023

asmorkalov commented Nov 22, 2023

dkurt commented Nov 22, 2023

asmorkalov commented Nov 22, 2023

asmorkalov left a comment

asmorkalov commented Nov 23, 2023

AleksandrPanov commented Nov 23, 2023

AleksandrPanov commented Nov 23, 2023

In-house QR codes decoding #24299

In-house QR codes decoding #24299

Conversation

dkurt commented Sep 20, 2023 • edited by opencv-alalek Loading

Pull Request Readiness Checklist

AleksandrPanov commented Nov 17, 2023 • edited Loading

AleksandrPanov left a comment

Choose a reason for hiding this comment

dkurt commented Nov 17, 2023

AleksandrPanov commented Nov 17, 2023

dkurt commented Nov 17, 2023

dkurt commented Nov 20, 2023 • edited Loading

asmorkalov Nov 22, 2023

Choose a reason for hiding this comment

dkurt Nov 22, 2023

Choose a reason for hiding this comment

asmorkalov commented Nov 22, 2023

dkurt commented Nov 22, 2023

asmorkalov commented Nov 22, 2023

asmorkalov left a comment

Choose a reason for hiding this comment

asmorkalov commented Nov 23, 2023

AleksandrPanov commented Nov 23, 2023

AleksandrPanov commented Nov 23, 2023

dkurt commented Sep 20, 2023 •

edited by opencv-alalek

Loading

AleksandrPanov commented Nov 17, 2023 •

edited

Loading

dkurt commented Nov 20, 2023 •

edited

Loading