Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ChessBoardDetector::findQuadNeighbors #24597

Conversation

MaximSmolskiy
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov
Copy link
Contributor

AleksandrPanov commented Nov 29, 2023

you have opened PR #24605. Do you need this PR if you fix "const float ediff" in #24605 PR as well?

Although it may be better to add changes in parts.

@MaximSmolskiy
Copy link
Contributor Author

you have opened PR #24605. Do you need this PR if you fix "const float ediff" in #24605 PR as well?

The main important change here not in const, but in adding fabs.
Yes, I need this PR and want to divide these changes:

  • this PR is about fixing bug
  • second PR about equivalent acceleration

So, I want to merge this PR first and then update second PR with these changes

Copy link
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov added this to the 4.9.0 milestone Nov 30, 2023
@asmorkalov asmorkalov merged commit 10c43e5 into opencv:4.x Nov 30, 2023
25 of 26 checks passed
@MaximSmolskiy MaximSmolskiy deleted the fix-bug-in-ChessBoardDetector-findQuadNeighbors branch November 30, 2023 08:01
IskXCr pushed a commit to Haosonn/opencv that referenced this pull request Dec 20, 2023
…ardDetector-findQuadNeighbors

Fix bug in ChessBoardDetector::findQuadNeighbors opencv#24597

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
…ardDetector-findQuadNeighbors

Fix bug in ChessBoardDetector::findQuadNeighbors opencv#24597

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants