Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G-API: Soften the argument check in infer2 #24615

Merged
merged 1 commit into from Nov 29, 2023
Merged

G-API: Soften the argument check in infer2 #24615

merged 1 commit into from Nov 29, 2023

Conversation

smirnov-alexey
Copy link
Contributor

@smirnov-alexey smirnov-alexey commented Nov 29, 2023 •
edited

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@smirnov-alexey
Copy link
Contributor Author

This PR fixes https://github.com/openvinotoolkit/open_model_zoo/tree/master/demos/gesture_recognition_demo/cpp_gapi

TolyaTalamanov
TolyaTalamanov approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@TolyaTalamanov TolyaTalamanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dmatveev
dmatveev approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 strange we didn't have tests failing because of that

@smirnov-alexey
Copy link
Contributor Author

The default PR check is failing due to abi issues which are not related to this PR but to dnn module for some reason

@smirnov-alexey
Copy link
Contributor Author

@asmorkalov @mshabunin can we merge this please?

@asmorkalov asmorkalov added this to the 4.9.0 milestone Nov 29, 2023
@asmorkalov asmorkalov merged commit 5df28f1 into opencv:4.x Nov 29, 2023
25 of 26 checks passed
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatveev dmatveev dmatveev approved these changes

@TolyaTalamanov TolyaTalamanov TolyaTalamanov approved these changes

Assignees

@dmatveev dmatveev

Labels
category: g-api / gapi
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smirnov-alexey @dmatveev @TolyaTalamanov @asmorkalov