-
-
Notifications
You must be signed in to change notification settings - Fork 55.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G-API OV backend requires cv::MediaFrame #24938
G-API OV backend requires cv::MediaFrame #24938
Conversation
Need to investigate this issue in one of the test cases - WIP:
|
Will be glad to help if it hasn't been resolved yet |
Thanks a lot! |
8e87508
to
633ccf9
Compare
Opened this PR for review. This issue is going to be addressed in a follow-up ticket - 111291. |
@TolyaTalamanov could you please review this PR? |
34960ec
to
58cb0ff
Compare
// Assert | ||
validate(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opencv_test_gapi --gtest_filter=*MediaFrameTestAgeGenderOV*
CTEST_FULL_OUTPUT
OpenCV version: 4.9.0-dev
OpenCV VCS version: 4.9.0-106-gbde2400e29-dirty
Build type: Release
Compiler: /usr/bin/c++ (ver 9.4.0)
Parallel framework: pthreads (nthreads=6)
CPU features: SSE SSE2 SSE3 *SSE4.1 *SSE4.2 *FP16 *AVX *AVX2 *AVX512-SKX?
Intel(R) IPP version: ippIP AVX2 (l9) 2021.10.0 (-) Sep 18 2023
Intel(R) IPP features code: 0x8000
OpenCL is disabled
TEST: Skip tests with tags: 'mem_6gb', 'verylong'
Note: Google Test filter = *MediaFrameTestAgeGenderOV*
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from MediaFrameTestAgeGenderOV
[ RUN ] MediaFrameTestAgeGenderOV.InferMediaInputBGR
[ OK ] MediaFrameTestAgeGenderOV.InferMediaInputBGR (118 ms)
[ RUN ] MediaFrameTestAgeGenderOV.InferROIGenericMediaInputBGR
[ OK ] MediaFrameTestAgeGenderOV.InferROIGenericMediaInputBGR (72 ms)
[----------] 2 tests from MediaFrameTestAgeGenderOV (190 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (190 ms total)
[ PASSED ] 2 tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Can we also cover NV12
test cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks! 24e5ceb
@TolyaTalamanov could you please review this PR? |
e58497b
to
17cbb67
Compare
@asmorkalov hi! Could you please advise how to run all pre-commit checks, not just the |
@DariaMityagina Github actions are triggered automatically for OpenCV organization members only. I approved built for you. |
Great, thank you! |
// Assert | ||
validate(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Can we also cover NV12
test cases?
Hello! Will get back to this PR soon. Thanks! |
833bd89
to
b1a8203
Compare
b1a8203
to
7d58666
Compare
@asmorkalov hi! Could you please trigger the checks again? |
@TolyaTalamanov hi! Could you please take a look at the PR? |
@asmorkalov hi! Could you please trigger the checks again? I fixed tests failure. |
@asmorkalov hi! Could you please trigger the checks again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you so much 🔥
LGTM 👍
@asmorkalov hi! Can this PR be merged? Could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, thanks @DariaMityagina !
@asmorkalov thanks! |
Fixed build warnings introduced in #24938
…frame-support-to-govbackend G-API OV backend requires cv::MediaFrame opencv#24938 ### Pull Request Readiness Checklist **Background_subtraction demo G-API issue. Update:** Porting to API20 resulted in an error (both for CPU and NPU): ``` [ERROR] OpenCV(4.9.0-dev) /home/runner/work/open_model_zoo/open_model_zoo/cache/opencv/modules/gapi/src/backends/ov/govbackend.cpp:813: error: (-215: assertion not done ) cv::util::holds_alternative<cv::GMatDesc>(input_meta) in function 'cfgPreProcessing' ``` Adding cv::MediaFrame support to govbackend resulted in the following (tested with CPU): <img width="941" alt="image" src="https://github.com/opencv/opencv/assets/52502732/3a003d61-bda7-4b1e-9117-3410cda1ba32"> ### TODO - [ ] **As part of the review process [this comment](opencv#24938 (comment)) was addressed which make it impossible to run the demo. I will bring those changes back in a separate PR [support `PartialShape`]** See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Pull Request Readiness Checklist
Background_subtraction demo G-API issue. Update:
Porting to API20 resulted in an error (both for CPU and NPU):
Adding cv::MediaFrame support to govbackend resulted in the following (tested with CPU):
TODO
PartialShape
]See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.