Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qrcode bugs #25026

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Fix qrcode bugs #25026

merged 8 commits into from
Feb 16, 2024

Conversation

akretz
Copy link
Contributor

@akretz akretz commented Feb 14, 2024

This PR fixes #22892, #24011 and #24450 and adds regression tests using the images provided. I've also verified with the benchmark that this doesn't break anything there.

resolves #22892
resolves #24011
resolves #24450
Replaces #23802

Requires extra: opencv/opencv_extra#1148

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

No regressions in QR code benchmark: opencv/opencv_benchmarks#9

@dkurt
Copy link
Member

dkurt commented Feb 15, 2024

There is one optional comment to test data: https://github.com/opencv/opencv_extra/pull/1148/files#r1490488836. If it's possible to test regression on grayscale image, I recommend to use it.

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 68f6c81 into opencv:4.x Feb 16, 2024
25 of 27 checks passed
@jabdoa2
Copy link

jabdoa2 commented Feb 16, 2024

Thank you that :-)!

@asmorkalov asmorkalov mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants