-
-
Notifications
You must be signed in to change notification settings - Fork 55.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix qrcode bugs #25026
Fix qrcode bugs #25026
Conversation
62106ed
to
3c84e94
Compare
No regressions in QR code benchmark: opencv/opencv_benchmarks#9 |
There is one optional comment to test data: https://github.com/opencv/opencv_extra/pull/1148/files#r1490488836. If it's possible to test regression on grayscale image, I recommend to use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you that :-)! |
This PR fixes #22892, #24011 and #24450 and adds regression tests using the images provided. I've also verified with the benchmark that this doesn't break anything there.
resolves #22892
resolves #24011
resolves #24450
Replaces #23802
Requires extra: opencv/opencv_extra#1148
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.