New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
features2d cleanup: Move several feature detectors and descriptors to opencv_contrib #25292
base: 5.x
Are you sure you want to change the base?
Conversation
|
I propose to migrate corresponding tutorials, python and java tests to contrib too. |
<https://github.com/pablofdezalc/test_kaze_akaze_opencv> | ||
|
||
\warning You need the <a href="https://github.com/opencv/opencv_contrib">OpenCV contrib modules</a> to be able to use the AKAZE features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use markdown notation for links.
@@ -17,6 +17,8 @@ Introduction | |||
In this tutorial we will compare *AKAZE* and *ORB* local features using them to find matches between | |||
video frames and track object movements. | |||
|
|||
\warning You need the <a href="https://github.com/opencv/opencv_contrib">OpenCV contrib modules</a> to be able to use the AKAZE features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use markdown notation for links.
|
Please pay attention on merge conflicts. |
Some of these tutorials are more about doing matching and tracking using the features which are to be migrated to contrib rather than the features alone, for example akaze_matching.markdown, akaze_tracking.markdown etc. Would replacing the features with one of those which are still in the main repo and keeping the tutorials be better than completely migrating them to contrib? And quite a few examples in the documentation use the SURF feature which is in contrib, for example https://docs.opencv.org/4.x/d7/dff/tutorial_feature_homography.html. Should we replace SURF with another feature as well? For tests, in many of them AKAZE is used as 'gold'. In this case will replace it with ORB or another feature which are in the main repo. |
…tor to contrib/xfeatures2d
19f05e6
to
4b75bad
Compare
features2d cleanup: #24999
The PR moves KAZE, AKAZE, AgastFeatureDetector, BRISK and BOW to opencv_contrib/xfeatures2d.
Related PR: opencv/opencv_contrib#3709