New HAL API for remap #25399
Merged
New HAL API for remap #25399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
force-pushed
the
as/HAL_remap
branch
2 times, most recently
from
506d2a6
to
9540edf
Compare
modules/imgproc/src/imgwarp.cpp
Outdated
| @@ -1816,6 +1815,10 @@ void cv::remap( InputArray _src, OutputArray _dst, | |||
| if( dst.data == src.data ) | |||
| src = src.clone(); | |||
|
|
|||
| if ((map1.type() == CV_32FC1) && (map2.type() == CV_32FC1)) | |||
| CALL_HAL(remap, cv_hal_remap, src.type(), src.data, src.step, src.cols, src.rows, dst.data, dst.step, dst.cols, dst.rows, | |||
There was a problem hiding this comment.
In general HAL API should be called unconditionally.
Or we need to rename API and apply 32f suffix.
vpisarev
reviewed
Apr 12, 2024
asmorkalov
force-pushed
the
as/HAL_remap
branch
from
9540edf
to
a4b4808
Compare
|
@opencv-alalek @vpisarev I fixed remarks:
|
opencv-alalek
approved these changes
Apr 17, 2024
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #25392
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.