0/1D test for tile layer #25409
Open
0/1D test for tile layer #25409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
Apr 17, 2024
asmorkalov
reviewed
Apr 18, 2024
Abdurrahheem
force-pushed
the
ash/0D-tile-test
branch
from
1101e4c
to
4b6c5c4
Compare
Abdurrahheem
force-pushed
the
ash/0D-tile-test
branch
from
4b6c5c4
to
724599b
Compare
|
@dkurt could you please give quick look if this PR good? |
dkurt
reviewed
Apr 23, 2024
dkurt
reviewed
Apr 23, 2024
|
@dkurt added removed tests |
|
@dkurt anything else? |
dkurt
added
the
backport is needed
dkurt
removed
the
backport is needed
dkurt
approved these changes
May 7, 2024
fengyuentau
reviewed
May 7, 2024
Comment on lines
+88
to
+106
| if (ndims > 1){ | ||
| for (int i = 0; i < ndims; i++) | ||
| { | ||
| rep_i = repeats[i]; | ||
| if (rep_i != 1) | ||
| { | ||
| tmp = tmp.reshape(0, dims); | ||
| tmp = cv::repeat(tmp, 1, rep_i); | ||
| } | ||
| dims *= out_shape[i]; | ||
| } | ||
| tmp = tmp.reshape(0, out_shape); | ||
| } else { | ||
| for (int i = 0; i < repeats.size(); i++){ | ||
| tmp = tmp.reshape(0, dims); | ||
| tmp = cv::repeat(tmp, 1, rep_i); | ||
| tmp = cv::repeat(tmp, repeats[i], 1); | ||
| dims *= out_shape[i]; | ||
| } | ||
| dims *= out_shape[i]; | ||
| tmp = tmp.reshape(0, out_shape); |
There was a problem hiding this comment.
Do these changes imply we need to do something to cv::repeat so that it can be used in the same way regardless 1D or 2D mat?
There was a problem hiding this comment.
may be. @dkurt what do you think?
asmorkalov
reviewed
May 7, 2024
| outputs[0][i] *= repeats[i]; | ||
| } | ||
| } else { | ||
| CV_CheckGE((int)repeats.size(), 1, "Provide at least one repeat along any dimention"); |
There was a problem hiding this comment.
"Tile: Provide at least one repeat along any dimension"
asmorkalov
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
0/1Dtest forTilelayer. It also add fuctionality to support0/1Dcases.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.