Additional fixes to 0/1D tests #25487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuentau
reviewed
Apr 25, 2024
modules/dnn/test/test_layers_1d.cpp
Outdated
|
|
||
| ASSERT_EQ(shape(output_ref), shape(outputs[0])); | ||
| ASSERT_EQ(1, outputs.size()); | ||
| ASSERT_EQ(shape(outputs[0]), shape(output_ref)); |
There was a problem hiding this comment.
Reference should be put in the first parameter and real output goes to the second.
See #25231 (comment).
There was a problem hiding this comment.
No, I mean it should be
ASSERT_EQ(1, outputs.size());
ASSERT_EQ(shape(output_ref), shape(outputs[0]));
| std::string opr = get<1>(GetParam()); | ||
|
|
||
| LayerParams lp; | ||
| lp.type = "Scatter"; | ||
| lp.name = "addLayer"; | ||
| lp.set("axis", 0); | ||
| lp.set("axis", axis); |
There was a problem hiding this comment.
axis = input_shape.size() - 1 should also work.
Abdurrahheem
force-pushed
the
ash/01D-additional-fixes
branch
from
3f05044
to
a4a606f
Compare
Abdurrahheem
force-pushed
the
ash/01D-additional-fixes
branch
from
a7eefb5
to
a818f25
Compare
Why do you create a new milestone? |
accidentally, sorry |
Abdurrahheem
force-pushed
the
ash/01D-additional-fixes
branch
from
101dfd6
to
7c59b39
Compare
Abdurrahheem
force-pushed
the
ash/01D-additional-fixes
branch
from
111d992
to
2e64f43
Compare
dkurt
reviewed
May 9, 2024
| std::vector<int>({1, 4}), | ||
| std::vector<int>({4, 4}) | ||
| ), | ||
| /*operation*/ testing::Values(0, 1) |
There was a problem hiding this comment.
Suggested change
| /*operation*/ testing::Values(0, 1) | |
| /*axis*/ testing::Values(0, 1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has additional fixes requited for 0/1D tests.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.