Fixed out-of-bound access in Einsum layer for 0d #25617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdurrahheem
force-pushed
the
ash/01D-einsum-test
branch
from
536944d
to
1f87402
Compare
dkurt
reviewed
May 22, 2024
| @@ -541,7 +541,7 @@ class LayerEinsumImpl CV_FINAL : public EinsumLayer | |||
| // Use either the preprocessed inputs (if it is available) or the corresponding raw inputs | |||
| result = pairwiseOperandProcess(!result.empty() ? result : rawInputs[0], | |||
| !result.empty() ? tmpResult : homogenizedInputDims[0], | |||
| !preProcessedInputs[input].empty() ? preProcessedInputs[input] : rawInputs[input], | |||
| (!preProcessedInputs.empty() && !preProcessedInputs[input].empty()) ? preProcessedInputs[input] : rawInputs[input], | |||
There was a problem hiding this comment.
The changes are not in OpenVINO part. How problem is reproduced?
There was a problem hiding this comment.
Before these changes, 0D test case would fail on OpenCV build with the openvino 2024 backend. @asmorkalov noticed it on his testing units.
There was a problem hiding this comment.
I think it fails not only on OpenVINO backend because of access to 0th element from empty vector. Just reproduced on OV backend. So I suggest rename a PR, because the change is generic.
dkurt
approved these changes
May 22, 2024
asmorkalov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Einsum layer 0D failure case for Openvino backend
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.