Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for cvSmooth -> tests for boxFilter #25634

Merged
merged 2 commits into from
May 25, 2024

Conversation

savuor
Copy link
Contributor

@savuor savuor commented May 24, 2024

fixes #25448

Motivation

The obsolete function cvSmooth has two modes in which it calls cv::boxFilter() inside with and without normalization.
This function is covered by tests exactly for that modes.
This means that by replacing cvSmooth call by cv::boxFilter() we will leave the coverage untouched (but more obvious) and remove that obsolete function from tests.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this May 25, 2024
@asmorkalov asmorkalov merged commit cc49aee into opencv:4.x May 25, 2024
28 of 30 checks passed
@savuor savuor deleted the rv/boxfilter_tests branch May 26, 2024 21:58
@opencv-alalek opencv-alalek removed their request for review May 27, 2024 12:58
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add acuracy test for box filter with and without normalization
2 participants