Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete lena.jpg and any use of it from the JS tutorials #25642

Open
wants to merge 4 commits into
base: 4.x
Choose a base branch
from

Conversation

arobase-che
Copy link
Contributor

@arobase-che arobase-che commented May 24, 2024

Pull Request Readiness Checklist

From the discussion of #25635.
Other references: #17461 #17713 #17714

For now, it only removes the Lena image from the JS tutorial.
Why only there ? Because it's easy and have more impact of the public image of OpenCV.

Every image I added came from the Kodak images set (often named Kodim) which is widely used in research papers.
I resized every image to be 400x400.
The dataset is available here: https://r0k.us/graphics/kodak/

The credit doesn't explicitly express the images are released for for unrestricted use but there are widely used already, even in the OpenCV extra repository.

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • [-] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [-] The feature is well documented and sample code can be built with the project CMake

@opencv-alalek
Copy link
Contributor

Please add detail into PR's description about the source and the license of added images.

Copy link
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are already existing images across OpenCV folders. Please choose between existing instead of adding new ones.

@arobase-che
Copy link
Contributor Author

I'm sorry, I'm a little busy at the moment. Will add more information and use OpenCV images as soon as I can.

@arobase-che
Copy link
Contributor Author

arobase-che commented May 26, 2024

Ok, I edited the PR and the images metadata to add the source of the images.

To make it easier to review, here is a comparison side by side of the differences.

adaptive_threshold_diff
affine_transform_diff
bilateral_filter_diff
convert_color_diff
convex_hull_diff
equalize_histogram_diff
face_detection_diff
gaussian_blur_diff
get_affine_transform_diff
image_approxPolyDP_diff
image_area_diff
image_bitwise_diff
image_blur_diff
image_canny_diff
image_CLAHE_diff
image_contours_diff
image_DFT_diff
image_filter_diff
image_GrabCut_diff
image_histogram_diff
image_InRange_diff
image_laplacian_diff
image_moments_diff
image_padding_diff
image_perimeter_diff
image_PyrDown_diff
image_PyrUp_diff
image_read_and_show_diff
image_resize_diff
image_ROI_diff
image_sobel_diff
image_threshold_diff
image_transpose_diff
intelligent_scissors_diff
median_blur_diff

This one is a little tricky. It didn't work with Lena on the first model.
object_detection_diff
perspectiv_transform_diff
rotate_transform_diff
style_transfer_diff
template_match_diff

About using already used images. I'm looking for images so. I can't find ones in the doc directory that fit the need, especially the face recognition example.
Otherwise, apple.jpg and orange.jpg are OK but not really good.
In the directory samples I found:

But none is good for the face detection example. Even group1 and group3 (which I guess use something better to detect faces).

From the opencv_extra repository.
I found those images that are interesting:

Note that there is 2 images from the Kodim (statue.png and kodim23.png).
Also, statue.png works for face detection but only one eye is visible (and detected), I didn' know if it's a problem or not.

Please help me to choose images if the ones I have chosen are not good. If I have to take only one image, I think we can choose statue.png.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants