Solves issue 3258 #3031
Closed
Solves issue 3258 #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you!
|
… to ptrdiff_t whenever appropriate.
|
@ramiromagalhaes this is a useful fix 😃 There are some loss of data warnings left |
|
this patch is useful perhaps, but it's a) incomplete (only PPM format reader is extended to handle huge images) and b) still produces some warnings. Let's close it until the next attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a pull request to solve issue 3258. I already submited it once, but due to time restrictions I could not solve all requests and it ended up closed by @vpisarev.
I think I have addressed all issues everyone has mentioned previously and I think it can be pulled this time. Please, take a look at it.