Fix #6500 cmake bug to build using NVCC #6590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,7 +128,7 @@ if(CUDA_FOUND) | |||
| foreach(ARCH IN LISTS ARCH_LIST) | |||
| if(ARCH MATCHES "([0-9]+)\\(([0-9]+)\\)") | |||
| # User explicitly specified PTX for the concrete BIN | |||
| set(NVCC_FLAGS_EXTRA ${NVCC_FLAGS_EXTRA} -gencode arch=compute_${CMAKE_MATCH_2},code=sm_${CMAKE_MATCH_1}) | |||
| set(NVCC_FLAGS_EXTRA ${NVCC_FLAGS_EXTRA} -D_FORCE_INLINES -gencode arch=compute_${CMAKE_MATCH_2},code=sm_${CMAKE_MATCH_1}) | |||
There was a problem hiding this comment.
In this case the -D_FORCE_INLINES will be added multiple times, since we are inside foreach loop.
I think it will be better to add this flag after the loop:
set(NVCC_FLAGS_EXTRA ${NVCC_FLAGS_EXTRA} -D_FORCE_INLINES)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6500
Similar to what was done at BVLC/caffe#4046
What does this PR change?
Single line that adds
-D_FORCE_INLINESto the cuda detection line.Thanks @chapaev28 for finding out where it actually goes.