Parallel SVM::trainAuto: uses parallel_for_ to dispatch all parameters combination … #9310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovrasov
reviewed
Aug 8, 2017
modules/ml/src/svm.cpp
Outdated
| Mat temp_train_responses(train_sample_count, 1, rtype); | ||
| Mat temp_test_responses; | ||
|
|
||
| int i,j,k,p; |
There was a problem hiding this comment.
Please, don't use obsolete C-style loop variables declaration.
There was a problem hiding this comment.
Just copy/pasted the original code. I was thinking to follow the coding rules doing like this
There was a problem hiding this comment.
If only my 3 loops are using C++ style loop declaration and ALL the rest of SVM code is using C-style, this will look weird
There was a problem hiding this comment.
SVM code already contains the both styles, take a look at static bool solve_* functions.
There was a problem hiding this comment.
Corrected.
If it is OK for you, I will merge the 2 commits
modules/ml/src/svm.cpp
Outdated
|
|
||
| vector<int> sidx; | ||
| setRangeVector(sidx, sample_count); | ||
|
|
||
| int i, j, k; | ||
| int i, k; |
There was a problem hiding this comment.
The same thing about loop variables.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVM::trainAuto is just 6 loops. I create a list of tasks and compute them using parallel_for_
This pullrequest changes
Add parallel functionality to SVM::trainAuto