Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sfm fixes #1169

Merged
merged 3 commits into from May 18, 2017
Merged

Sfm fixes #1169

merged 3 commits into from May 18, 2017

Conversation

PhilLab
Copy link
Contributor

@PhilLab PhilLab commented May 18, 2017

Fixes compilation error with MSVC < 2015 and enables refinement of intrinsics

@sovrasov
Copy link
Contributor

👍

@opencv-pushbot opencv-pushbot merged commit 363097e into opencv:master May 18, 2017
opencv-pushbot pushed a commit that referenced this pull request May 18, 2017
@PhilLab
Copy link
Contributor Author

PhilLab commented May 18, 2017

Mentioning @edgarriba , just in case the other way around was intended (disabling intrinsic refinement everywhere instead of enabling it everywhere)

@PhilLab PhilLab deleted the sfmFixes branch May 18, 2017 11:33
@LaurentBerger
Copy link
Contributor

LaurentBerger commented May 28, 2017

@PhilLab ( and @edgarriba) with your PR I have got some problem to run example given in doc (Sagrada Familia) because of this line
Without optimisation example is able to reconstruct scene but unable to reconstruction when parameters are refined.

I understand that your PR is usefull but I think a function must be added to sfm classe which can process parameters given in libmv_ReconstructionOptions libmv_CameraIntrinsicsOptions
My questions are : can you reproduce problem with example? What do you think about a new method?

Thanks for your answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants