[GSoC 2017] DeepGaze1 + Discriminant Saliency + BackgroundContrast #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyle and comment will be handled later\nFinish module design\nWorking on realizing training function and fixing saliency map computing bugs\n
…ency. Path is hardcoded, need to be fix
Masterqsx
force-pushed
the
saliency_shengxin_gsoc2017
branch
from
7f270b3
to
c6756c0
Compare
Masterqsx
changed the title
Masterqsx
force-pushed
the
saliency_shengxin_gsoc2017
branch
from
caadbb4
to
1ee9867
Compare
Masterqsx
changed the title
…ze1 sample work without calculating AUC
sovrasov
reviewed
Oct 27, 2017
| @@ -165,6 +165,7 @@ namespace cv { | |||
| // Generate mask | |||
| Mat mask = regions == r; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please revert this useless change.
| // of this distribution and at http://opencv.org/license.html. | ||
|
|
||
| #include <opencv2/imgproc.hpp> | ||
| #include <opencv2/highgui.hpp> |
There was a problem hiding this comment.
Please remove useless includes like highgui and imgcodecs. We shouldn't rely on modules which are not listed in dependencies list (see CMake).
| { | ||
| fgWeightDig.at<double>(i, i) = fg.at<double>(i, 0); | ||
| } | ||
| //temp = (smoothDeri - smoothWeight + bgWeightDig + fgWeightDig); |
There was a problem hiding this comment.
Here and everywhere please remove the dead commented code.
| @@ -40,6 +40,9 @@ | |||
| //M*/ | |||
|
|
|||
| #include "precomp.hpp" | |||
| #include <iostream> | |||
There was a problem hiding this comment.
Changes in this file are seems to be useless, so please revert them.
| This method uses seed superpixel algorithm to partition the image and calculate the probability of belonging to background with CIE-Lab color contrast. | ||
| This method also provides an optimization framework may help foreground based saliency method perform better. | ||
| */ | ||
| class CV_EXPORTS_W BackgroundContrast : public StaticSaliency |
There was a problem hiding this comment.
I think it's better to rename this class to BackgroundContrastSaliency. The current name is misleading.
| @@ -0,0 +1,149 @@ | |||
| name: "CaffeNet" | |||
There was a problem hiding this comment.
Why did you put the modified prototxt to the unrelated module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project: Improve Background Subtraction with Aggregated Saliency
Mentor: @lenlen