Gsoc opencv project : The Fast Bilateral Filter #1317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@THUKey No need to re-open PRs. Just push updates on your branch. |
alalek
reviewed
Nov 8, 2017
| typedef std::map<long long /* hash */, int /* vert id */> mapId; | ||
| #else | ||
| #include <boost/unordered_map.hpp> | ||
| typedef boost::unordered_map<long long /* hash */, int /* vert id */> mapId; |
There was a problem hiding this comment.
OpenCV should not depend on "boost" library
|
|
||
|
|
||
| // int debugn = blurs.nonZeros(); //FIXME: if don't call nonZeros(), the result will be destroy | ||
| // debugn = 0; |
| *colorPix = *gray_pix; | ||
| colorPix++; | ||
| } | ||
| gray_pix++; |
There was a problem hiding this comment.
cvtColor(gray, color, COLOR_GRAY2RGB)
| { | ||
| Size sz(rnd.uniform(512, 1024), rnd.uniform(512, 1024)); | ||
|
|
||
| int guideCn = rnd.uniform(1, 2); |
There was a problem hiding this comment.
result is always 1 here: "a <= x < b"
| Ptr<FastBilateralSolverFilter> createFastBilateralSolverFilter(InputArray, double, double, double, int, double) | ||
| { | ||
| std::cout << "ERROR createFastBilateralSolverFilter : don't have eigen" << '\n'; | ||
| exit(0); |
There was a problem hiding this comment.
CV_Error(Error::StsNotImplemented, ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the source file for FastBilateralSolverFilter(located in modules/ximgproc/src/fbs_filter.cpp), and add the class declaration to the file modules/ximgproc/include/opencv2/ximgproc/edge_filter.hpp.
the test file and some sample(depth and colorization) for FastBilteralSolverFilter will be add next week.
TODO list: