int to proper enum type #1730
Closed
int to proper enum type #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Aug 23, 2018
| @@ -278,7 +278,7 @@ bool ocl_getAllDCTDescriptorsForImage( const Mat *imgCh, std::vector< GPCPatchDe | |||
| (int)globSize[0], (int)globSize[1], (int)patchRadius ) | |||
| .run( 2, globSize, 0, true ) == false ) | |||
| return false; | |||
| Mat cpuOut = out.getMat( 0 ); | |||
cv3d
force-pushed
the
improvements/enum_interface
branch
from
b3ee644
to
ea0c8be
Compare
alalek
approved these changes
Aug 23, 2018
|
@cv3d Please rebase this patch onto 3.4 branch. |
cv3d
force-pushed
the
improvements/enum_interface
branch
from
ea0c8be
to
271f2bc
Compare
cv3d
force-pushed
the
improvements/enum_interface
branch
14 times, most recently
from
a04b8d2
to
80c87b9
Compare
cv3d
force-pushed
the
improvements/enum_interface
branch
7 times, most recently
from
4bf90e6
to
f7e2c88
Compare
cv3d
force-pushed
the
improvements/enum_interface
branch
11 times, most recently
from
e0f8c10
to
fee14d4
Compare
cv3d
force-pushed
the
improvements/enum_interface
branch
5 times, most recently
from
97fd65e
to
41564d1
Compare
cv3d
force-pushed
the
improvements/enum_interface
branch
3 times, most recently
from
fad2209
to
b84f892
Compare
cv3d
force-pushed
the
improvements/enum_interface
branch
from
b84f892
to
0184e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with opencv/opencv#12288 and opencv/opencv_extra#515
This pullrequest changes
There are hundreds of unnamed enums, and they are being passed as int in the C++ interface.
In order to avoid passing a wrong value, and to maintain good practices, the hope is to name most of these enums, and change the int arguments into the proper enum types wherever possible.