Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SURF: make test tolerate to rounding error #3426

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

tomoaki0705
Copy link
Contributor

Pull Request Readiness Checklist

closes #3377
relates #2587

Stop using condition build and make the test itself tolerance to rounding error.
Sooner or later same issue might appear on OpenCL implementation, so make the UMat version also telerate

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-pushbot opencv-pushbot merged commit b01f2f9 into opencv:3.4 Jan 21, 2023
@alalek alalek mentioned this pull request Jan 21, 2023
@tomoaki0705 tomoaki0705 deleted the handleNonBitExact branch January 21, 2023 21:45
@alalek alalek mentioned this pull request Jan 28, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants