Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote cv::VideoCapture properties in VideoReader #3485

Merged
merged 1 commit into from May 16, 2023
Merged

Promote cv::VideoCapture properties in VideoReader #3485

merged 1 commit into from May 16, 2023

Conversation

asmorkalov
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cudawarped
Copy link
Contributor

cudawarped commented Apr 27, 2023 •
edited

Nice, I can't for the life of me remember why I would have done it the way. Seems error prone looking back if any of the VideoCapture properties failed to be set.

@asmorkalov
Copy link
Contributor Author

@cudawarped I reworked tests a bit. Could you take a look again?

@asmorkalov asmorkalov changed the title WIP: Promote cv::VideoCapture properties in VideoReader Promote cv::VideoCapture properties in VideoReader May 3, 2023
@asmorkalov
Copy link
Contributor Author

@cudawarped I restored create-only parameters handling and related tests. Do you have any opens? May I merge the PR?

@cudawarped
Copy link
Contributor

LGTM 👍

@asmorkalov asmorkalov self-assigned this May 16, 2023
@asmorkalov asmorkalov merged commit e59b737 into opencv:4.x May 16, 2023
6 of 7 checks passed
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cudawarped cudawarped cudawarped left review comments

Assignees

@asmorkalov asmorkalov

Labels
bug category: cuda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asmorkalov @cudawarped