Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Charuco/Calib tutorials and samples to main repo #3708

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

AleksandrPanov
Copy link
Contributor

@AleksandrPanov AleksandrPanov commented Mar 29, 2024

Merge with opencv/opencv#25378
Move Charuco/Calib tutorials and samples to main repo:

  • update/fix charuco_detection.markdown and samples
  • update/fix charuco_diamond_detection.markdown and samples
  • update/fix aruco_calibration.markdown and samples
  • update/fix aruco_faq.markdown
  • move tutorials, samples and tests to main repo
  • remove old tutorials, samples and tests from contrib

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov added category: documentation Documentation fix or update, does not affect code category: samples category: aruco labels Mar 29, 2024
@asmorkalov asmorkalov self-requested a review March 29, 2024 08:11
@AleksandrPanov
Copy link
Contributor Author

@asmorkalov, could you remove opencv_test_aruco from opencv_contrib github CI?
image

@AleksandrPanov AleksandrPanov marked this pull request as draft April 12, 2024 10:21
@asmorkalov
Copy link
Contributor

Related changes in CI: opencv/ci-gha-workflow#169

@AleksandrPanov AleksandrPanov marked this pull request as ready for review April 12, 2024 11:06
asmorkalov pushed a commit to opencv/opencv that referenced this pull request Apr 16, 2024
Move Charuco/Calib tutorials and samples to main repo #25378

Merge with opencv/opencv_contrib#3708

Move Charuco/Calib tutorials and samples to main repo:

- [x] update/fix charuco_detection.markdown and samples
- [x] update/fix charuco_diamond_detection.markdown and samples
- [x] update/fix aruco_calibration.markdown and samples
- [x] update/fix aruco_faq.markdown
- [x] move tutorials, samples and tests to main repo
- [x] remove old tutorials, samples and tests from contrib


### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov self-assigned this Apr 16, 2024
@asmorkalov asmorkalov merged commit 2e63693 into opencv:4.x Apr 16, 2024
10 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 16, 2024
klatism pushed a commit to klatism/opencv that referenced this pull request May 17, 2024
…rial

Move Charuco/Calib tutorials and samples to main repo opencv#25378

Merge with opencv/opencv_contrib#3708

Move Charuco/Calib tutorials and samples to main repo:

- [x] update/fix charuco_detection.markdown and samples
- [x] update/fix charuco_diamond_detection.markdown and samples
- [x] update/fix aruco_calibration.markdown and samples
- [x] update/fix aruco_faq.markdown
- [x] move tutorials, samples and tests to main repo
- [x] remove old tutorials, samples and tests from contrib


### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: aruco category: documentation Documentation fix or update, does not affect code category: samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants