Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename getInteractionMatrix() to computeInteractionMatrix() #3724

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

catree
Copy link
Contributor

@catree catree commented Apr 21, 2024

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

see #3641

cc @simutisernestas @savuor

I prefer to use computeInteractionMatrix() instead of getInteractionMatrix() naming.
I have added references to some classical papers on this subject. Even if it is out of scope, they can be useful.

Warning, one bibtex reference already exist in the main opencv repo. I don't know if we can use @cite defined in the main repo?

Copy link
Contributor

@savuor savuor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, see no problem

@asmorkalov asmorkalov merged commit 3c2bcbf into opencv:4.x Apr 25, 2024
10 checks passed
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants