New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dense sift #442
base: 4.x
Are you sure you want to change the base?
Dense sift #442
Conversation
thanks for the contribution! Unfortunately there is a merge conflict in modules/optflow/CMakeLists.txt |
I am just wondering, since it is a |
I will try solving the merge conflict later this week. I didn't check with them about the license, but because I am using the SIFT descriptor, everything has to be in the nonfree module anyhow. |
@YuvalNirkin , This is very nice work ! Regarding the license as @StevenPuttemans noticed i am looking at: http://people.csail.mit.edu/celiu/ECCV2008/release.zip original matlab demonstrator, i believe you followed that implementation (but i might be wrong, you might followed the raw paper).
For citations better would be to add them inside My few +1 (pure opinions, with my best positive intentions here):
Again very nice work ! Wonder if i or someone could pickup author's next one brilliant co-work on same subject: http://vision.cs.utexas.edu/projects/dsp , had it in my mind myself , and now you really opened the path to it with present SIFTflow. |
@YuvalNirkin , @StevenPuttemans
I would try enhance the code in the directions proposed by me. |
@StevenPuttemans |
Thank You Very Much ! Will do the proposed cosmetic and parallelization. For descriptor part i'll try to an universal api so user just pass a Lets see together. |
@YuvalNirkin @cbalint13 still considering to fix this and getting it in? |
There is a merge conflict that I don't know how to fix in modules/optflow/CMakeLists.txt. The master branch's modules/optflow/CMakeLists.txt: Maybe somebody can help with that.. |
Could you try adding
which adds the normal libs first and then the contribs one. I am guessing it has to do with some sort of conflict there. |
Or you could create a clean local branch and force push it on top of this with the same name, to make sure it is not a hidden character screwing it up. |
You have to take the master version of the cmakefile. |
…o DenseSIFT Conflicts: modules/optflow/CMakeLists.txt
@cbalint13, @StevenPuttemans, @Dikay900 Now on Windows machines I get that 'Eigen/Sparse' header can't be found. How can i overcome this problem? |
My best guess is that the Eigen version of OpenCV is lower then 3.2.8 (https://eigen.tuxfamily.org/dox/group__TutorialSparse.html) and thus it does not contain this yet ... But to be sure we need some admin to confirm this. @alalek can you confirm this might be the case? |
I have added a generalized optical flow algorithm called SIFT flow that can work on images with the same scene characteristics.
Link to the article:
http://people.csail.mit.edu/celiu/SIFTflow/