-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yolox in c++ #177
yolox in c++ #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Here is a minor modification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model was added last year in a GSoC project. We had a plan that an integrated API in objdetect module (something like cv::FaceDetectorYN
) should be composed after the GSoC project was finished. However, the student kind of quit. Would you like to make such a contribution in opencv main repo?
{ | ||
cout << nbInference << " inference made. Demo existing" << endl; | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should make any assumption that the user want to run certain times of inference and then exit. Pressing a key to exit is enough.
@LaurentBerger Friendly reminder. |
thanks for reminder. |
No, you dont need to close this pr. We can merge this one if comments are all addressed. Also I was asking whether you have time working on another pr for opencv objdetect module in my previous comment. |
Yes, exactly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Ok I will make a pr before sept-15 |
@asmorkalov @fengyuentau |
@LaurentBerger Yes, it is still in the todo list. You are welcome to do that if you want. |
Yolox in c++
Option v and s are not used in demo.py
Values mean and std are not used too in demo.py
I think blobFromImageWithParams can be used but it will not give same result:
border is set to 0 (not 114) and crop is done relative to image center (not (0,0) )