Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yolox in c++ #177

Merged
merged 4 commits into from
Aug 9, 2023
Merged

yolox in c++ #177

merged 4 commits into from
Aug 9, 2023

Conversation

LaurentBerger
Copy link
Contributor

@LaurentBerger LaurentBerger commented Jun 15, 2023

Yolox in c++
Option v and s are not used in demo.py

Values mean and std are not used too in demo.py

I think blobFromImageWithParams can be used but it will not give same result:
border is set to 0 (not 114) and crop is done relative to image center (not (0,0) )

Copy link
Member

@WanliZhong WanliZhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Here is a minor modification.

models/object_detection_yolox/demo.cpp Outdated Show resolved Hide resolved
Copy link
Member

@WanliZhong WanliZhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model was added last year in a GSoC project. We had a plan that an integrated API in objdetect module (something like cv::FaceDetectorYN) should be composed after the GSoC project was finished. However, the student kind of quit. Would you like to make such a contribution in opencv main repo?

models/object_detection_yolox/CMakeLists.txt Outdated Show resolved Hide resolved
models/object_detection_yolox/demo.cpp Outdated Show resolved Hide resolved
{
cout << nbInference << " inference made. Demo existing" << endl;
break;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should make any assumption that the user want to run certain times of inference and then exit. Pressing a key to exit is enough.

@fengyuentau
Copy link
Member

@LaurentBerger Friendly reminder.

@fengyuentau fengyuentau self-assigned this Aug 8, 2023
@fengyuentau fengyuentau added the demo anything related to demo in Python / C++ label Aug 8, 2023
@LaurentBerger
Copy link
Contributor Author

thanks for reminder.
Now If i understand well I must close this pr and reopen one in opencv isn't it?

@fengyuentau
Copy link
Member

Now If i understand well I must close this pr and reopen one in opencv isn't it?

No, you dont need to close this pr. We can merge this one if comments are all addressed.

Also I was asking whether you have time working on another pr for opencv objdetect module in my previous comment.

@LaurentBerger
Copy link
Contributor Author

LaurentBerger commented Aug 8, 2023

another pr for opencv objdetect module in my previous comment.

Do you mean nanodet?

Ok I understand now add a new classe now here

@fengyuentau
Copy link
Member

Yes, exactly.

Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fengyuentau fengyuentau merged commit d84d6d6 into opencv:main Aug 9, 2023
@LaurentBerger
Copy link
Contributor Author

Ok I will make a pr before sept-15

@LaurentBerger
Copy link
Contributor Author

This model was added last year in a GSoC project. We had a plan that an integrated API in objdetect module (something like cv::FaceDetectorYN) should be composed after the GSoC project was finished. However, the student kind of quit. Would you like to make such a contribution in opencv main repo?

@asmorkalov @fengyuentau
Can you confirm that it is still in to do list?

@fengyuentau
Copy link
Member

Can you confirm that it is still in to do list?

@LaurentBerger Yes, it is still in the todo list. You are welcome to do that if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demo anything related to demo in Python / C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants