Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object_Detection: YoloX (GSOC) #86

Closed
wants to merge 122 commits into from
Closed

Conversation

Sidd1609
Copy link
Contributor

@Sidd1609 Sidd1609 commented Aug 19, 2022

Updated files for object detection using YOLOX,
files uploaded for review:

  • Model files (.onnx format FP16)
  • Models: YOLOX_s, YOLOX_tiny, YOLOX_nano
  • README
  • LICENSE (Apache 2.0)
  • demo.py (with image and webcam inference options)
  • YoloX.py (class YoloX)
  • examples (test_data: test images, results: inferred results)
  • COCO class names (coco.names)

COMPLETED:

  • YOLOX ONNX models (FP16): YOLOX_S, YOLOX_tiny, YOLOX_nano
  • ReadMe
  • License
  • Sample Images and Results
  • Video Inference

TO DO:

  • Model Quantization

@Sidd1609 Sidd1609 changed the title Gsoc_YoloX Object_Detection: YOLOX Aug 19, 2022
@Sidd1609 Sidd1609 changed the title Object_Detection: YOLOX Object_Detection: YOLOX (GSOC) Aug 19, 2022
@Sidd1609 Sidd1609 changed the title Object_Detection: YOLOX (GSOC) Object_Detection: YoloX (GSOC) Aug 19, 2022
@fengyuentau fengyuentau self-assigned this Aug 19, 2022
@fengyuentau fengyuentau added the GSoC Google Summer of Code projected related label Aug 19, 2022
@fengyuentau
Copy link
Member

This PR is for YoloX, so please remove the object_detection_nanodet directory.

@Sidd1609
Copy link
Contributor Author

removed nanodet directory

models/object_detection_yolox/YoloX.py Outdated Show resolved Hide resolved
models/object_detection_yolox/YoloX.py Outdated Show resolved Hide resolved
models/object_detection_yolox/YoloX.py Outdated Show resolved Hide resolved
models/object_detection_yolox/YoloX.py Outdated Show resolved Hide resolved
models/object_detection_yolox/YoloX.py Outdated Show resolved Hide resolved
models/object_detection_yolox/YoloX.py Outdated Show resolved Hide resolved
models/object_detection_yolox/coco.names Outdated Show resolved Hide resolved
models/object_detection_yolox/demo.py Outdated Show resolved Hide resolved
models/object_detection_yolox/demo.py Outdated Show resolved Hide resolved
models/object_detection_yolox/demo.py Outdated Show resolved Hide resolved
@Sidd1609

This comment was marked as resolved.

@fengyuentau
Copy link
Member

@Sidd1609 Could you squash commits into one? I am going to work on this pr and merge it this weekend if possible.

@Sidd1609
Copy link
Contributor Author

Sidd1609 commented Oct 21, 2022 via email

@fengyuentau
Copy link
Member

image

You can see here in the picture you have 128 commits in total for this PR. When merging a PR, we don't need such a long commit history and we prefer only one commit. Learn more details here. You could squash commits with the following commands:

$ git rebase -i HEAD~128 # number 128 is the number of your commits in this PR
# Then an editor will pop up. Leave the first commit as pick,
# and change the other commits from pick to squash. Exit the
# editor and a new page on the commit message will be opened.
# Compose a short and clear commit message and exit the editor.
# Squashing commits is done.

There is a page talking details on squashing commits: https://www.git-tower.com/learn/git/faq/git-squash

@Sidd1609
Copy link
Contributor Author

Sidd1609 commented Oct 21, 2022 via email

@fengyuentau
Copy link
Member

I think both the commits for nanodet and yolox have been taken into consideration

That's why these two PRs should be based on different branches. I will start working on your PRs when commits are squashed.

@Sidd1609
Copy link
Contributor Author

Sidd1609 commented Oct 21, 2022 via email

@fengyuentau
Copy link
Member

close in favor of #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code projected related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants