implement entity id attr pick-up mech and fix #31 #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fully addresses #31 and partially addresses #32.
get_entity_id_attribute()
insrc/kestrel/codegen/relations.py
to compute the appropriate attribute used as identifier attribute for entities.src/kestrel/codegen/commands.py
to useget_entity_id_attribute()
.or_pattern()
for post-prefetch merge insrc/kestrel/codegen/commands.py
withfirepit.merge()
(partially address codegen upgrade: use firepit to merge variables #32).get_variable_entity_count()
insrc/kestrel/codegen/summary.py
to useget_entity_id_attribute()
._get_variable_query_ids()
insrc/kestrel/codegen/summary.py
since merged variable infirepit
do not have__membership
records.gen_variable_summary()
insrc/kestrel/codegen/summary.py
to only give cached records when there is a data source query.