Consider nullability and type in predicates: #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Return NULL in wrong predicate type - Handle NULL in where conditions - Fix bug when string predicates were not recognized as `WHERE` conditions - `Choose` case class variations to simplify code in rewriters TCK +7 Signed-off-by: Dwitry dwitry@users.noreply.github.com
…ull checks. Signed-off-by: Dwitry dwitry@users.noreply.github.com
dwitry
added a commit
to dwitry/cypher-for-gremlin
that referenced
this pull request
Jan 18, 2019
- Additional predicate to check string type - Return NULL in wrong predicate type - Fix bug when string predicates were not recognized as `WHERE` conditions - Merge changes from opencypher#191 TCK +3 Signed-off-by: Dwitry dwitry@users.noreply.github.com
dwitry
added a commit
to dwitry/cypher-for-gremlin
that referenced
this pull request
Jan 18, 2019
- Additional predicate to check string type - Return NULL in wrong predicate type - Fix bug when string predicates were not recognized as `WHERE` conditions - Merge changes from opencypher#191 TCK +3 Signed-off-by: Dwitry dwitry@users.noreply.github.com
dwitry
added a commit
that referenced
this pull request
Jan 18, 2019
- Additional predicate to check string type - Return NULL in wrong predicate type - Fix bug when string predicates were not recognized as `WHERE` conditions - Merge changes from #191 TCK +3 Signed-off-by: Dwitry dwitry@users.noreply.github.com
|
Most of changes were gradually closed in #230 and other commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHEREconditionsChoosecase class variations to simplify code in rewritersTCK +7
Signed-off-by: Dwitry dwitry@users.noreply.github.com