Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft for binary switch based on extended CAPSSession #897

Closed
wants to merge 3 commits into from

Conversation

s1ck
Copy link
Contributor

@s1ck s1ck commented Apr 18, 2019

Extends CAPSSession with SPIP API via mixin trait. The trait and necessary adapters are bundled within a single package. This allows a seamless switch between SPIP and OKAPI API in a single graph app by switching the session implementation. See GraphApp for an example.

Pro:

  • no additional module
  • seamless binary switch between CAPS and SPIP
  • CAPS spark-cypher can be renamed to morpheus-spark-cypher or morpheus

Cons:

  • as with v1, it feels a bit weird that similar named methods return equally named results but with different semantics, but I guess that's what we just need to deal with

Needs apache/spark#24297 installed locally to compile and run.

@Mats-SX
Copy link
Member

Mats-SX commented Apr 23, 2019

I think I like this one better than the alternative, but I'm not sure I understand all of the implications. Very nice examples though!

@s1ck s1ck closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants