Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Safari and iPhone Safari #10

Merged
merged 3 commits into from
Dec 7, 2016

Conversation

ubahnverleih
Copy link
Contributor

Added Support for Safari and mobile Safari.

  • added fetch polyfill
  • fixed viewport for mobile
  • added overflow scroll for sidebar

@rashfael
Copy link
Collaborator

rashfael commented Dec 7, 2016

Thanks!
I don't have an iDevice, so I can't test it for Safari, working for mobile Chrome.

Does the scroll-overflow help anything on Safari, doesn't make that much sense for Chrome.
Sidebar should be responsive and dismissable anyway.

@rashfael rashfael merged commit 5ca976f into opendata-stuttgart:master Dec 7, 2016
@ubahnverleih
Copy link
Contributor Author

Overflow scroll also helps in Desktop browser, when showing more sensors in sidebar. (zoomed out)

@rashfael
Copy link
Collaborator

rashfael commented Dec 8, 2016

That would be overflow-y, not overflow-x though, if we want the vertical list to be scrollable.

@ubahnverleih
Copy link
Contributor Author

ok, overflow-y would be the right one and i don't know why overflow-x has the same effect. And auto would be the better value

@ubahnverleih
Copy link
Contributor Author

fixed in PR #12

@rashfael
Copy link
Collaborator

rashfael commented Dec 8, 2016

overflow is a bit quirky, certain combinations for x/y are not possible: http://stackoverflow.com/questions/6421966/css-overflow-x-visible-and-overflow-y-hidden-causing-scrollbar-issue/6433475#6433475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants