expose ConnectionQuery::dateType (time arrival or departure)

[benib]

The dateType for the ConnectionQuery should be exposed. This is mentioned in issue #47. Currently it is hard coded to be a departure time.
How should this be exposed. I think a dateType variable which can be set to 1 or 0 is not as clear as it should be.
What about isDepartureTime?

[fabian]

Hmm, yes I guess adding a flag is better than adding a second time parameter like departureTime, as that's how it usually will be used.

How about timeType with values departure and arrival?

[1tchy]

I think passing a parameter isDepartureTime=0 is clear to be the arrival time. And isDepartureTime=1 is clear to be the departure.

[colinfrei]

I'd rather name the argument so that it's clear instead of adding an additional parameter.

So have a departuretime and an arrivaltime argument, and throw a 400 error if you get both.

[benib]

@colinfrei: this would mean we have depdate, deptime, arrdate and arrtime.
I think a parameter isArrivalTime would be the best, as this defaults to 0.

[colinfrei]

The downside is that it makes it more magic. in my eyes arguments of which it's obvious what they do are always better than arguments where it's not obvious, even if that means having more arguments.

For example you'd still have the situation where it is like it is now, and you're not sure if arrival or departure is meant.

[benib]

I agree about the magic but i think that in this case, it would be easier for everybody to have some magic.
Think about a simple form where you can set the date/time and select departure or arrival (as the sbb.ch form). then you can handle the date/time the same way, and just add the isArrivalTime if arrival is selected.
Thats also the way, the xmlfahrplan API handles this, so we don't have to fiddle around internally.

Defaulting to departure is the way every fahrplan application handles this. so this is clear for me.

[1tchy]

Whether the parameter is an isArrivalTime or isDepartureTime doesn't really matter for me. However, I agree with benib that there should be one extra parameter and not two changed and two invented ones. And I agree, it should default to departure. So it's indeed smarter to have the default isArrivalTime=0.

[akuendig]

+1 This would be a great addition

[fabian]

PR merged.