Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null template index driver #1236

Merged
merged 7 commits into from Mar 1, 2022
Merged

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Feb 25, 2022

Proposed changes

Implement a "null" index driver - an always empty index

Reason for this pull request

Mostly this a validation that alternate index drivers can be defined and tested, and a template for implementing future index drivers. It may also be convenient for ODC use cases that do not require an index.

  • Tests added / passed
  • Fully documented, including docs/about/whats_new.rst for all changes

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1236 (8711689) into develop (38a314a) will increase coverage by 1.14%.
The diff coverage is 97.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1236      +/-   ##
===========================================
+ Coverage    92.71%   93.86%   +1.14%     
===========================================
  Files          103      109       +6     
  Lines        10598    10757     +159     
===========================================
+ Hits          9826    10097     +271     
+ Misses         772      660     -112     
Impacted Files Coverage Δ
datacube/index/postgres/_products.py 94.01% <ø> (+0.07%) ⬆️
datacube/index/null/_users.py 90.00% <90.00%> (ø)
datacube/index/abstract.py 95.73% <93.75%> (+0.83%) ⬆️
datacube/index/null/index.py 94.11% <94.11%> (ø)
datacube/index/null/__init__.py 100.00% <100.00%> (ø)
datacube/index/null/_datasets.py 100.00% <100.00%> (ø)
datacube/index/null/_metadata_types.py 100.00% <100.00%> (ø)
datacube/index/null/_products.py 100.00% <100.00%> (ø)
datacube/index/postgres/_metadata_types.py 93.97% <100.00%> (-0.28%) ⬇️
datacube/index/postgres/index.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a314a...8711689. Read the comment docs.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review February 28, 2022 01:27
Copy link
Contributor

@alexgleith alexgleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Love that you're tacking all this!

@SpacemanPaul SpacemanPaul merged commit 4230478 into develop Mar 1, 2022
@SpacemanPaul SpacemanPaul deleted the null_template_index_driver branch March 1, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants