Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address dependabot alerts, regenerate constraints.txt #1250

Merged
merged 4 commits into from May 12, 2022
Merged

Address dependabot alerts, regenerate constraints.txt #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1c7b53
Address dependabot alerts, regenerate constraints.txt
SpacemanPaul May 11, 2022
d28ea3b
Handle changes in click API, pin compliance-checker and sync dask and…
SpacemanPaul May 12, 2022
1ec7529
Fix geometry tests.
SpacemanPaul May 12, 2022
d68bf51
Update whats_new.rst
SpacemanPaul May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion datacube/scripts/search_tool.py
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@

import csv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone else dislike the naming of this module scripts. IMO it should be cli.

Maybe it doesn't matter, but I think of scripts as being quite different to a fully fledged and essential command line tool...

import datetime
import shutil
import sys
from functools import partial

Expand All @@ -27,7 +28,7 @@ def printable_values(d):
return {k: printable(v) for k, v in d.items()}


def write_pretty(out_f, field_names, search_results, terminal_size=click.get_terminal_size()):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, I don't even think this datacube-search thing should exist any more. I don't know why it ever did. The one or two commands it supports should be moved under datacube dataset or datacube product`.

def write_pretty(out_f, field_names, search_results, terminal_size=shutil.get_terminal_size()):
"""
Output in a human-readable text format. Inspired by psql's expanded output.
"""
Expand Down
6 changes: 3 additions & 3 deletions docker/constraints.in
View file
Open in desktop
Expand Up @@ -9,9 +9,9 @@ celery>=4,<5
ciso8601
click>=8.0
cloudpickle>=0.4
compliance-checker>=4.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, compliance checker is only for checking NetCDF metadata compliance.

If we ever get to the point of making NetCDF support optional, it can be optional too.

dask>=2021.5.1
distributed>=2021.5.1
compliance-checker>=4.0.0,<5
dask>=2021.10.1
distributed>=2021.10.0
fiona
jsonschema
lark-parser>=0.6.7
Expand Down