New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire deprecations #1275
Merged
Merged
Retire deprecations #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and associated tests: deprecated since 1.8.0.
…check_field_indexes. Deprecated since 1.5.4.
Codecov Report
@@ Coverage Diff @@
## develop #1275 +/- ##
===========================================
- Coverage 93.58% 93.48% -0.11%
===========================================
Files 129 128 -1
Lines 13203 12952 -251
===========================================
- Hits 12356 12108 -248
+ Misses 847 844 -3
Continue to review full report at Codecov.
|
Kirill888
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Many features/syntax have been flagged as deprecated in previous releases. Some have been deprecated for quite some time.
Proposed changes
Deprecated features/syntax removed in this PR:
datacube.helpers.write_geotiff
(Deprecated in v1.8.0)auto_match
argument todc.index.datasets.add()
(Deprecated in v1.6.0)rasterio
reader. (Deprecated in 1.8.0)rebuild_all
argument to `dc.index.metadata_types.check_field_index(). (Deprecated in 1.5.4)dc.index.datasets.add()
. (Deprecated in 1.5.4 (!))Corresponding test cases also removed.
Deprecated behaviour NOT removed in this PR:
virtual products transforms deprecated in PR deprecate Rename, Select and ToFloat transformations #1263
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes