Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire deprecations #1275

Merged
merged 9 commits into from Jun 15, 2022
Merged

Retire deprecations #1275

merged 9 commits into from Jun 15, 2022

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Jun 8, 2022

Reason for this pull request

Many features/syntax have been flagged as deprecated in previous releases. Some have been deprecated for quite some time.

Proposed changes

Deprecated features/syntax removed in this PR:

  • datacube.helpers.write_geotiff (Deprecated in v1.8.0)
  • auto_match argument to dc.index.datasets.add() (Deprecated in v1.6.0)
  • celery executor (Deprecated in v1.8.7)
  • deriving CRS from datum/zone (Deprecated in 1.8.0)
  • support for broken/mossing geospatial driver from rasterio reader. (Deprecated in 1.8.0)
  • rebuild_all argument to `dc.index.metadata_types.check_field_index(). (Deprecated in 1.5.4)
  • source policy support in dc.index.datasets.add(). (Deprecated in 1.5.4 (!))

Corresponding test cases also removed.

Deprecated behaviour NOT removed in this PR:

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1275 (5ed060e) into develop (82ed29c) will decrease coverage by 0.10%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop    #1275      +/-   ##
===========================================
- Coverage    93.58%   93.48%   -0.11%     
===========================================
  Files          129      128       -1     
  Lines        13203    12952     -251     
===========================================
- Hits         12356    12108     -248     
+ Misses         847      844       -3     
Impacted Files Coverage Δ
datacube/executor.py 65.08% <ø> (+0.55%) ⬆️
datacube/helpers.py 33.33% <ø> (-42.28%) ⬇️
datacube/index/memory/_datasets.py 89.64% <ø> (-0.22%) ⬇️
datacube/index/null/_datasets.py 100.00% <ø> (ø)
datacube/index/postgis/_datasets.py 94.47% <ø> (-0.12%) ⬇️
datacube/index/postgres/_datasets.py 94.75% <ø> (-0.12%) ⬇️
datacube/model/__init__.py 95.89% <ø> (-0.30%) ⬇️
datacube/scripts/dataset.py 88.13% <ø> (-0.11%) ⬇️
datacube/storage/_rio.py 93.05% <50.00%> (-1.07%) ⬇️
datacube/index/abstract.py 96.17% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ed29c...5ed060e. Read the comment docs.

@SpacemanPaul SpacemanPaul merged commit 87db1d9 into develop Jun 15, 2022
@SpacemanPaul SpacemanPaul deleted the retire_deprecations branch June 15, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants