New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flake8 and pylint to lint workflow #1285
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1285 +/- ##
===========================================
- Coverage 93.47% 93.43% -0.05%
===========================================
Files 128 128
Lines 12958 12953 -5
===========================================
- Hits 12113 12103 -10
- Misses 845 850 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments on a very large but minor PR.
Happy to debate any of them if anybody disagrees with my takes.
Reason for this pull request
When commits are checked by pre-commit and flake8 code lint was corrected, it applies to lines that were committed without flake8 causing extra lines of changes shown in a pull request increasing difficulty in reviewing.
Adding flake8 to code lint as part of GitHub action ensures commits with or without pre-commit checks are all passing flake8 code lint.
Proposed changes
create
lint.yaml
for code lint run as part of PR actionadd flake8 for code lint as per
pre-commit
hookstreamline github action, move
pycodestyle
andpylint
out of build and into lintapply flake8 lint correction to all effected lines
add more ignore to
setup.cfg
Closes Flake is used in pre-commit but not in github action #1284
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes