Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic spatial index tables. #1312

Merged
merged 7 commits into from Aug 18, 2022
Merged

Dynamic spatial index tables. #1312

merged 7 commits into from Aug 18, 2022

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Aug 18, 2022 •
edited

Reason for this pull request

Progress on ODCv2 roadmap

Proposed changes

  • API to dynamically create a Postgis table to serve as a spatial index for a particular CRS.
  • Complexity mostly comes from distinguishing between spatial index tables that exist in a particular database from spatial index tables that the SQLAlchemy ORM knows about.

Note that the spatial index tables are not being populated or used yet - this will come in subsequent PRs.

Tests failing because of Issue #1311

  • Tests added / passed
  • Fully documented, including docs/about/whats_new.rst for all changes

@SpacemanPaul SpacemanPaul marked this pull request as ready for review August 18, 2022 01:17
@SpacemanPaul SpacemanPaul requested a review from omad August 18, 2022 01:17
omad
omad approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@omad omad merged commit 846c572 into develop Aug 18, 2022
@omad omad deleted the dynamic_spatiotemp_indexes branch August 18, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omad omad omad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SpacemanPaul @omad