Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgis cleanup #1368

Closed
wants to merge 7 commits into from
Closed

Postgis cleanup #1368

wants to merge 7 commits into from

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Dec 12, 2022

Reason for this pull request

Cleanup and refactor of postgis index driver and cross-driver tests. Motivated by need for new EO3-only lineage implementation.

Proposed changes

  • Remove from postgis driver the old implementation inherited from legacy driver for adding lineage in the dataset add.

  • Resulting refactor of tests motivated by above.

  • NB Remaining minor test coverage drop mostly due to removal of (covered) code.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1368.org.readthedocs.build/en/1368/

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 92.75% // Head: 92.70% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (6e069b5) compared to base (5c42f81).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1368      +/-   ##
===========================================
- Coverage    92.75%   92.70%   -0.06%     
===========================================
  Files          130      130              
  Lines        13627    13607      -20     
===========================================
- Hits         12640    12614      -26     
- Misses         987      993       +6     
Impacted Files Coverage Δ
datacube/scripts/dataset.py 89.41% <ø> (+0.27%) ⬆️
datacube/index/postgis/_datasets.py 71.14% <90.90%> (-1.80%) ⬇️
datacube/drivers/postgis/_api.py 85.60% <0.00%> (-1.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review December 12, 2022 09:23
@SpacemanPaul SpacemanPaul requested review from omad and removed request for omad December 12, 2022 09:23
@SpacemanPaul SpacemanPaul marked this pull request as draft December 12, 2022 09:28
@SpacemanPaul SpacemanPaul marked this pull request as ready for review December 13, 2022 01:33
@SpacemanPaul
Copy link
Contributor Author

Superseded by #1372

@omad omad deleted the postgis-cleanup branch December 16, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant