Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more SQLAlchemy 2.0 deprecation warnings. #1407

Merged
merged 3 commits into from Feb 27, 2023
Merged

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Feb 21, 2023

Still many SQLAlchemy 2.0 deprecation warnings coming out of test runs.

Reason for this pull request

Complete work begun in #1403.

Proposed changes

  • Address outstanding SQLAlchemy 2.0 deprecation warnings in tests.

  • Remove long deprecated datacube.storage.masking API (moved to `datacube.utils.masking around v1.8)

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1407.org.readthedocs.build/en/1407/

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 91.96% // Head: 91.96% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (de95bbb) compared to base (46ce315).
Patch coverage: 95.29% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1407      +/-   ##
===========================================
- Coverage    91.96%   91.96%   -0.01%     
===========================================
  Files          133      132       -1     
  Lines        14452    14450       -2     
===========================================
- Hits         13291    13289       -2     
  Misses        1161     1161              
Impacted Files Coverage Δ
datacube/drivers/postgis/_connections.py 83.45% <ø> (ø)
datacube/index/postgis/_datasets.py 74.81% <0.00%> (ø)
datacube/index/postgis/_products.py 93.43% <ø> (ø)
datacube/index/postgres/_products.py 94.57% <ø> (ø)
datacube/drivers/postgres/_dynamic.py 90.76% <75.00%> (+0.14%) ⬆️
datacube/drivers/postgis/_core.py 94.94% <96.00%> (-0.06%) ⬇️
datacube/drivers/postgres/_core.py 96.26% <96.87%> (-0.04%) ⬇️
datacube/drivers/postgis/_api.py 87.28% <100.00%> (ø)
datacube/drivers/postgis/sql.py 83.63% <100.00%> (ø)
datacube/drivers/postgres/_api.py 96.40% <100.00%> (+0.02%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

datacube/drivers/postgis/_api.py Outdated Show resolved Hide resolved
datacube/drivers/postgis/_core.py Outdated Show resolved Hide resolved
datacube/drivers/postgres/_api.py Outdated Show resolved Hide resolved
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@omad omad merged commit e58edce into develop Feb 27, 2023
@omad omad deleted the sqla_deprecations_fix2 branch February 27, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants