Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs footer links #1417

Merged
merged 2 commits into from Mar 22, 2023
Merged

Fix docs footer links #1417

merged 2 commits into from Mar 22, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Mar 21, 2023

Reason for this pull request

The links contained in the documentation footer only work when running locally; once actually deployed, they are broken.

Proposed changes

  • Use /page/ redirect in link. This is broken locally but should work in the deployed docs.

  • Add exclude pattern in conf to fix file name too long error from nbsphinx when building

  • Closes links on read the doc footer leads to 404 #1343

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1417.org.readthedocs.build/en/1417/

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6cb67da) 91.84% compared to head (5202db8) 91.84%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1417   +/-   ##
========================================
  Coverage    91.84%   91.84%           
========================================
  Files          132      132           
  Lines        14466    14466           
========================================
  Hits         13286    13286           
  Misses        1180     1180           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ariana-B Ariana-B changed the title an attempt Fix docs footer links Mar 21, 2023
@Ariana-B Ariana-B requested a review from pindge March 21, 2023 03:58
@Ariana-B Ariana-B merged commit 523d5fd into develop Mar 22, 2023
23 checks passed
@Ariana-B Ariana-B deleted the fix_doc_footer_links branch March 22, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

links on read the doc footer leads to 404
3 participants