Update S3 indexing example #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1418 +/- ##
========================================
Coverage 91.84% 91.84%
========================================
Files 132 132
Lines 14466 14466
========================================
Hits 13286 13286
Misses 1180 1180 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
pindge
approved these changes
Mar 22, 2023
SpacemanPaul
approved these changes
Mar 22, 2023
| @@ -41,7 +41,7 @@ take some time, but will add a continental product to your local Datacube. | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| datacube product add https://data.dea.ga.gov.au/geomedian-australia/v2.1.0/product-definition.yaml | |||
| s3-to-dc --no-sign-request 's3://dea-public-data/geomedian-australia/v2.1.0/L8/**/*.yaml' ls8_nbart_geomedian_annual | |||
| datacube product add https://explorer.nci.dea.ga.gov.au/products/ga_ls8c_nbart_gm_cyear_3.odc-product.yaml | |||
There was a problem hiding this comment.
Why are we referencing NCI explorer here? I'm sure the AWS product definition is the same, but we should probably use the AWS explorer anyway.
There was a problem hiding this comment.
I referenced nci explorer because I noticed that the product yamls used in tests reference nci, so I figured that was the way to go... changed.
|
Update whats_new.rst as well please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
The S3 indexing example in the docs is outdated.
Proposed changes
Change example to Landsat 8 geomedian
Closes digital earth au decommissioned collection 2 geomedian doc is out of date #1342
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1418.org.readthedocs.build/en/1418/