Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add license hook to pre-commit #1438

Merged
merged 5 commits into from May 10, 2023
Merged

add license hook to pre-commit #1438

merged 5 commits into from May 10, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented May 8, 2023

Reason for this pull request

See #1310

Proposed changes


📚 Documentation preview 📚: https://datacube-core--1438.org.readthedocs.build/en/1438/

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (082933f) 91.84% compared to head (df7f48f) 91.84%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1438   +/-   ##
========================================
  Coverage    91.84%   91.84%           
========================================
  Files          132      132           
  Lines        14466    14466           
========================================
  Hits         13286    13286           
  Misses        1180     1180           
Impacted Files Coverage Δ
datacube/__init__.py 100.00% <ø> (ø)
datacube/api/__init__.py 100.00% <ø> (ø)
datacube/api/core.py 95.64% <ø> (ø)
datacube/api/grid_workflow.py 97.05% <ø> (ø)
datacube/api/query.py 93.71% <ø> (ø)
datacube/config.py 97.61% <ø> (ø)
datacube/drivers/__init__.py 100.00% <ø> (ø)
datacube/drivers/_tools.py 100.00% <ø> (ø)
datacube/drivers/_types.py 100.00% <ø> (ø)
datacube/drivers/datasource.py 100.00% <ø> (ø)
... and 120 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ariana-B Ariana-B requested review from omad and SpacemanPaul May 9, 2023 05:24
Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

239 files changed??!?! Ai yai yai!!!

Oh right, I see.

Needs a whats_new.rst entry, otherwise all good.

@Ariana-B
Copy link
Contributor Author

Ariana-B commented May 10, 2023

Needs a whats_new.rst entry, otherwise all good.

Whoops! Thought I'd done that but clearly not. Done.

@Ariana-B Ariana-B merged commit e001515 into develop May 10, 2023
22 of 24 checks passed
@Ariana-B Ariana-B deleted the pre_commit_license_hook branch May 10, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pre-commit hook to verify license headers
2 participants