New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odc geo follow throughs #1441
Odc geo follow throughs #1441
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1441 +/- ##
===============================================
- Coverage 85.63% 85.53% -0.10%
===============================================
Files 134 134
Lines 14958 14943 -15
===============================================
- Hits 12809 12782 -27
- Misses 2149 2161 +12
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through this Ariana.
I'd like to Damien to have a look before we merge if possible.
Reason for this pull request
See #1440
Proposed changes
Complete further aspects of odc-geo migration: replacing
GridSpec
and someutils.math
functionsFollow odc-geo conventions, and raise warnings where this might be contrary to previous conventions or cause ambiguity
Also take the opportunity to standardise
geobox
parameter names where possible, as raised in Standardise geobox parameter names across reprojection functions #1032Closes 1.9: Follow through API ramifications from odc-geo incompatibilities. #1440
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes