Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odc geo follow throughs #1441

Merged
merged 14 commits into from Jun 1, 2023
Merged

Odc geo follow throughs #1441

merged 14 commits into from Jun 1, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented May 11, 2023

Reason for this pull request

See #1440

Proposed changes

tests/test_utils_other.py Outdated Show resolved Hide resolved
@Ariana-B Ariana-B marked this pull request as ready for review May 16, 2023 05:00
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 87.96% and project coverage change: -0.10 ⚠️

Comparison is base (5c96e60) 85.63% compared to head (eef30ce) 85.53%.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1441      +/-   ##
===============================================
- Coverage        85.63%   85.53%   -0.10%     
===============================================
  Files              134      134              
  Lines            14958    14943      -15     
===============================================
- Hits             12809    12782      -27     
- Misses            2149     2161      +12     
Impacted Files Coverage Δ
datacube/api/grid_workflow.py 97.05% <ø> (ø)
datacube/utils/__init__.py 100.00% <ø> (ø)
datacube/utils/geometry/tools.py 14.12% <0.00%> (ø)
datacube/virtual/impl.py 72.88% <ø> (ø)
datacube/utils/math.py 89.47% <61.90%> (-10.53%) ⬇️
datacube/api/core.py 94.85% <77.77%> (-0.85%) ⬇️
datacube/drivers/netcdf/_write.py 100.00% <100.00%> (ø)
datacube/drivers/netcdf/writer.py 94.70% <100.00%> (ø)
datacube/model/__init__.py 96.09% <100.00%> (+0.03%) ⬆️
datacube/storage/_load.py 100.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this Ariana.

I'd like to Damien to have a look before we merge if possible.

datacube/api/core.py Outdated Show resolved Hide resolved
@Ariana-B Ariana-B linked an issue May 23, 2023 that may be closed by this pull request
@omad omad merged commit 2a7cca7 into develop-1.9 Jun 1, 2023
20 checks passed
@omad omad deleted the odc_geo_follow_throughs branch June 1, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.9: Follow through API ramifications from odc-geo incompatibilities.
5 participants