Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve archive_less_mature compatibility with odc-tools #1452

Merged
merged 7 commits into from Jun 6, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented May 31, 2023

Reason for this pull request

odc-tools also uses the archive_less_mature functionality, but additionally needs to be able to access the less mature datasets to public the STAC document to an SNS topic. With the current implementation of archive_less_mature, this requires a lot of duplicate code.

Proposed changes

  • Split the search logic in archive_less_mature into a new function, find_less_mature, that simply returns a list of the less mature Datasets

  • Allow a leniency of 1ms in searching for other maturity versions of a dataset

  • Closes #xxxx

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1452.org.readthedocs.build/en/1452/

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 90.00% and no project coverage change.

Comparison is base (b34d375) 91.82% compared to head (c6f73fe) 91.82%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1452   +/-   ##
========================================
  Coverage    91.82%   91.82%           
========================================
  Files          132      132           
  Lines        14510    14516    +6     
========================================
+ Hits         13324    13330    +6     
  Misses        1186     1186           
Impacted Files Coverage Δ
datacube/index/fields.py 96.77% <ø> (ø)
datacube/index/abstract.py 88.28% <90.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SpacemanPaul
Copy link
Contributor

Actually - can we round the time off to the nearest millisecond, as requested by James Miller in SnS #1188

@Ariana-B Ariana-B merged commit ec00a7f into develop Jun 6, 2023
25 checks passed
@Ariana-B Ariana-B deleted the cli_maturity_model_2 branch June 6, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants