Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ingestion #1465

Merged
merged 6 commits into from Jun 27, 2023
Merged

Remove ingestion #1465

merged 6 commits into from Jun 27, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Jun 23, 2023

Reason for this pull request

Ingestion is marked as deprecated in 1.8.14; remove in 1.9

Proposed changes

  • Remove everything ingestion-related

  • Closes #xxxx

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.86 ⚠️

Comparison is base (b198cc4) 85.54% compared to head (45e711b) 84.68%.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1465      +/-   ##
===============================================
- Coverage        85.54%   84.68%   -0.86%     
===============================================
  Files              134      132       -2     
  Lines            14993    14591     -402     
===============================================
- Hits             12826    12357     -469     
- Misses            2167     2234      +67     
Impacted Files Coverage Δ
datacube/api/__init__.py 100.00% <ø> (ø)
datacube/model/__init__.py 95.51% <ø> (-0.59%) ⬇️
datacube/scripts/cli_app.py 100.00% <ø> (ø)
datacube/virtual/impl.py 72.30% <33.33%> (-0.59%) ⬇️
datacube/drivers/netcdf/driver.py 88.88% <100.00%> (-11.12%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ariana-B Ariana-B marked this pull request as ready for review June 26, 2023 06:43
Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice to finally be clearing out some of the clutter.

@Ariana-B Ariana-B merged commit ede99c4 into develop-1.9 Jun 27, 2023
19 checks passed
@Ariana-B Ariana-B deleted the remove_ingestion branch June 27, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants