Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor improvements #1472

Merged
merged 3 commits into from Jul 18, 2023
Merged

Various minor improvements #1472

merged 3 commits into from Jul 18, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Jul 17, 2023

Reason for this pull request

Work done in odc-tools identified a few minor improvements to be made to core.

Proposed changes

  • Give archive_less_mature and find_less_mature default delta values so that they don't have to be specified when used elsewhere

  • Reduce ambiguity from product_matcher error by printing entire dataset definition doc instead of only the keys that are also present in the product rule signature

  • Mark some lineage flags as deprecated and to be deprecated, remove confirmation for ignore lineage option

  • Closes #xxxx

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1472.org.readthedocs.build/en/1472/

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (b3bc535) 91.76% compared to head (c00bc21) 91.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1472      +/-   ##
===========================================
+ Coverage    91.76%   91.78%   +0.02%     
===========================================
  Files          132      132              
  Lines        14540    14526      -14     
===========================================
- Hits         13342    13333       -9     
+ Misses        1198     1193       -5     
Impacted Files Coverage Δ
datacube/index/hl.py 100.00% <ø> (ø)
datacube/index/abstract.py 88.29% <100.00%> (ø)
datacube/scripts/dataset.py 88.73% <100.00%> (+1.04%) ⬆️
datacube/ui/common.py 97.91% <100.00%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SpacemanPaul SpacemanPaul merged commit 95b6f43 into develop Jul 18, 2023
22 checks passed
@SpacemanPaul SpacemanPaul deleted the var_minor_improvements branch July 18, 2023 00:41
SpacemanPaul pushed a commit that referenced this pull request Jul 18, 2023
* various minor improvements

* put back _resolve_uri

* update whats_new

---------

Co-authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants